[19.0][FIX] sale_exception: avoid false positive in 'Not Enough Virtual Stock' - #4520
Open
lef-adhoc wants to merge 1 commit into
Open
Conversation
The example rule compared self.virtual_available_at_date < self.product_uom_qty. On sale.order.line, virtual_available_at_date is False/0 for confirmed lines (state='sale') and whenever the stock widget is not displayed, so the comparison False < qty evaluates to True and the exception is wrongly raised (blocking edits on confirmed orders and intermittently on new draft lines, even when there is enough stock). Guard the rule so it only applies to draft/sent lines with the stock widget displayed and a real forecast value, keeping the legitimate block when the forecast is actually lower than the ordered quantity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-port of #4514 (18.0) to 19.0.
The example rule compared
self.virtual_available_at_date < self.product_uom_qty. On sale.order.line,virtual_available_at_dateis False/0 for confirmed lines (state='sale') and whenever the stock widget is not displayed, so the comparisonFalse < qtyevaluates to True and the exception is wrongly raised (blocking edits on confirmed orders and intermittently on new draft lines, even when there is enough stock).Guard the rule so it only applies to draft/sent lines with the stock widget displayed and a real forecast value, keeping the legitimate block when the forecast is actually lower than the ordered quantity.