[18.0][MIG] rma_sale_mrp: Migration to version 18.0 by eduezerouali-tecnativa · Pull Request #525 · OCA/rma

eduezerouali-tecnativa · 2026-01-15T08:04:53Z

victoralmau · 2026-02-02T13:08:54Z

rma_sale_mrp/views/sale_order_portal_template.xml

            >data.get('phantom_bom_product') and data['quantity'] or 0</attribute>
        </xpath>
-        <!-- TODO: We could give a clue about what's to be returned, with readonly detailed lines -->
+        <!-- TODO: We could give a clue about what's to be returned, with readonly detailed lines


Why is it necessary to comment on this now? If it is not necessary, the corresponding code should be removed and explained.

pedrobaeza · 2026-02-02T15:11:12Z

/ocabot migration rma_sale_mrp

victoralmau

It is not possible to select kit products on the portal.

v16

v18

mariancuadranetkia · 2026-02-20T08:24:33Z

It's not possible create RMA of a Kit, because we receive next error:

I'm not sure if this error could be because the 'delivery order' field isn't automatically filled in the kits, and that's why the validation is being skipped.:

In the wizard, if a component line didn't have any quantity, we could end in an infinite loop when creating the RMA.

[UPD] Update rma_sale_mrp.pot [UPD] README.rst

We must inform the component line maximum qty to return so we're able to properly discount every line on the wizard TT29876

rma_sale_mrp 13.0.2.0.0

- When creating an RMA for a kit from the portal, the description was lost for the components. rma_sale_mrp 13.0.2.0.1

[UPD] Update rma_sale_mrp.pot [UPD] README.rst

TT37303

As we rely on the kit_qty field have the kit/component relation an that's computed when the RMA is created, we want to avoid reopening the RMA to avoid inconsitencies. The user should create a new RMA. TT41943

- Standard procedure. - Rename changed fields. TT44949

Whenever we tried to edit a line belonging to a kit we couldn't finsish the RMA. The wizard view was unwittingly requiring this field which for the kit line shouldn't be required. TT45051

Currently translated at 100.0% (55 of 55 strings) Translation: rma-16.0/rma-16.0-rma_sale_mrp Translate-URL: https://translation.odoo-community.org/projects/rma-16-0/rma-16-0-rma_sale_mrp/es/

…s with phantom_bom_product set~

Currently translated at 100.0% (55 of 55 strings) Translation: rma-16.0/rma-16.0-rma_sale_mrp Translate-URL: https://translation.odoo-community.org/projects/rma-16-0/rma-16-0-rma_sale_mrp/pt_BR/

The rma operation is required in the portal, and it makes sense for it to be required in the sales wizard as well

Currently translated at 100.0% (57 of 57 strings) Translation: rma-16.0/rma-16.0-rma_sale_mrp Translate-URL: https://translation.odoo-community.org/projects/rma-16-0/rma-16-0-rma_sale_mrp/it/

Currently translated at 100.0% (57 of 57 strings) Translation: rma-16.0/rma-16.0-rma_sale_mrp Translate-URL: https://translation.odoo-community.org/projects/rma-16-0/rma-16-0-rma_sale_mrp/pt_BR/

- Display the allowed quantity to return - Simplify data encoding by adding a button to select/deselect all lines - Ensure that the quantity to return is always less than or equal to the allowed quantity

Currently translated at 100.0% (62 of 62 strings) Translation: rma-16.0/rma-16.0-rma_sale_mrp Translate-URL: https://translation.odoo-community.org/projects/rma-16-0/rma-16-0-rma_sale_mrp/it/

eduezerouali-tecnativa · 2026-03-04T15:23:50Z

@victoralmau sorry for the late replay, now it is working as it should.

eduezerouali-tecnativa · 2026-03-04T15:26:45Z

@mariancuadranetkia first thank you to take the time for the review. Could you give more detail on how you got the error. Anyways i think it has to do with not valid the picking.

mariancuadranetkia · 2026-03-05T06:29:07Z

@eduezerouali-tecnativa
I created a sale with table kit and I finished picking.
After that, I returned to sale order, and I created RMA. Although I could choose product kit to create RMA, when I 'accept' to create it, I got error.
I attach a short video, where you can see the sale order and picking, and error when I try to create RMA. This sale order is created in order to test this feature.

rma.kit.error.mp4

eduezerouali-tecnativa · 2026-03-05T08:46:55Z

@mariancuadranetkia the main problem is that you are using a kit with one product that it is not trackable. Try again creating your own products and components and you will see that RMA is create correctly.

mariancuadranetkia · 2026-03-05T13:13:49Z

@mariancuadranetkia the main problem is that you are using a kit with one product that it is not trackable. Try again creating your own products and components and you will see that RMA is create correctly.

Mmm yes, but, this way customer can't create RMA to ask for a refund if a product is not trackable or a component of kit is not trackable? Because, I can create a return picking without RMA without problem of this product not trackable, problem it's only creating RMA.

I'm not sure if this is the expected behaviour, but, if I can return a product and I can refund it, I don't understand the reason to not allow create RMA to register this operation.

eduezerouali-tecnativa force-pushed the 18.0-mig-rma_sale_mrp branch 2 times, most recently from de70770 to f301357 Compare January 15, 2026 09:05

victoralmau suggested changes Feb 2, 2026

View reviewed changes

eduezerouali-tecnativa force-pushed the 18.0-mig-rma_sale_mrp branch 2 times, most recently from 09c10e8 to 899ad94 Compare February 2, 2026 13:39

OCA-git-bot added this to the 18.0 milestone Feb 2, 2026

OCA-git-bot mentioned this pull request Feb 2, 2026

Migration to version 18.0 #425

Open

6 tasks

victoralmau suggested changes Feb 12, 2026

View reviewed changes

chienandalu and others added 20 commits March 4, 2026 16:20

[ADD] rma_sale_mrp: New module to refund kits

403c990

Added translation using Weblate (Portuguese)

82fbcdd

Added translation using Weblate (Portuguese (Brazil))

2b45bb5

[FIX] rma_sale_mrp: infinite loop

b37956f

In the wizard, if a component line didn't have any quantity, we could end in an infinite loop when creating the RMA.

[FIX] rma_sale_mrp: handle exceptions when qty is forced

e392b45

[IMP] rma_sale_mrp: black, isort, prettier

2a4cf7d

[MIG] rma_sale_mrp: Migration to 13.0

b40d8c7

[UPD] Update rma_sale_mrp.pot [UPD] README.rst

[FIX] rma_sale_mrp: portal rma

157aac8

We must inform the component line maximum qty to return so we're able to properly discount every line on the wizard TT29876

[FIX] rma_sale_mrp: fix view inherit chain

f2c5aa2

[FIX] rma_sale_mrp: invalid template

e1759fc

rma_sale_mrp 13.0.2.0.0

[FIX] rma_sale_mrp: description

0f521f9

- When creating an RMA for a kit from the portal, the description was lost for the components. rma_sale_mrp 13.0.2.0.1

[IMP] rma_sale_mrp: black, isort, prettier

39d073e

[mig] rma_sale_mrp: Migration to 14.0

4b536ba

[UPD] Update rma_sale_mrp.pot [UPD] README.rst

[IMP] rma_sale_mrp: black, isort, prettier

d219144

[MIG] rma_sale_mrp: Migration to 15.0

06cd59e

TT37303

[FIX] rma_sale_mrp: avoid reopening of kit RMAs

f3abe9b

As we rely on the kit_qty field have the kit/component relation an that's computed when the RMA is created, we want to avoid reopening the RMA to avoid inconsitencies. The user should create a new RMA. TT41943

[MIG] rma_sale_mrp: Migration to 16.0

2ffc88d

- Standard procedure. - Rename changed fields. TT44949

[IMP] rma_sale_mrp: bs4 -> bs5

c9f8fa5

[FIX] rma_sale_mrp: sale wizard line edition

4c5309b

Whenever we tried to edit a line belonging to a kit we couldn't finsish the RMA. The wizard view was unwittingly requiring this field which for the kit line shouldn't be required. TT45051

Translated using Weblate (Spanish)

7e7b399

Currently translated at 100.0% (55 of 55 strings) Translation: rma-16.0/rma-16.0-rma_sale_mrp Translate-URL: https://translation.odoo-community.org/projects/rma-16-0/rma-16-0-rma_sale_mrp/es/

mymage and others added 13 commits March 4, 2026 16:20

Added translation using Weblate (Italian)

38e90f6

[FIX] rma_sale_mrp: _check_rma_invoice_lines_qty checks now only line…

3c057dc

…s with phantom_bom_product set~

[FIX] uom_id in rma and rma_sale_mrp reports

98fffcd

Translated using Weblate (Portuguese (Brazil))

8c86dcd

Currently translated at 100.0% (55 of 55 strings) Translation: rma-16.0/rma-16.0-rma_sale_mrp Translate-URL: https://translation.odoo-community.org/projects/rma-16-0/rma-16-0-rma_sale_mrp/pt_BR/

[IMP] rma_sale: operation required

06a6508

The rma operation is required in the portal, and it makes sense for it to be required in the sales wizard as well

Translated using Weblate (Italian)

75f4d57

Currently translated at 100.0% (57 of 57 strings) Translation: rma-16.0/rma-16.0-rma_sale_mrp Translate-URL: https://translation.odoo-community.org/projects/rma-16-0/rma-16-0-rma_sale_mrp/it/

Translated using Weblate (Portuguese (Brazil))

84efb4d

Currently translated at 100.0% (57 of 57 strings) Translation: rma-16.0/rma-16.0-rma_sale_mrp Translate-URL: https://translation.odoo-community.org/projects/rma-16-0/rma-16-0-rma_sale_mrp/pt_BR/

[IMP] rma: improve rma report layout

4326a7f

[IMP] rma_sale: Display the allowed quantity to return in the RMA wizard

c08f4f3

- Display the allowed quantity to return - Simplify data encoding by adding a button to select/deselect all lines - Ensure that the quantity to return is always less than or equal to the allowed quantity

[FIX] rma: group rma receptions

f69c097

Translated using Weblate (Italian)

7371a19

Currently translated at 100.0% (62 of 62 strings) Translation: rma-16.0/rma-16.0-rma_sale_mrp Translate-URL: https://translation.odoo-community.org/projects/rma-16-0/rma-16-0-rma_sale_mrp/it/

[IMP] rma_sale_mrp: pre-commit auto fixes

04e4ac7

[MIG] rma_sale_mrp: Migration to 18.0

c57d0a2

eduezerouali-tecnativa force-pushed the 18.0-mig-rma_sale_mrp branch from 899ad94 to c57d0a2 Compare March 4, 2026 15:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[18.0][MIG] rma_sale_mrp: Migration to version 18.0#525

[18.0][MIG] rma_sale_mrp: Migration to version 18.0#525
eduezerouali-tecnativa wants to merge 33 commits intoOCA:18.0from
Tecnativa:18.0-mig-rma_sale_mrp

eduezerouali-tecnativa commented Jan 15, 2026

Uh oh!

victoralmau Feb 2, 2026

Uh oh!

pedrobaeza commented Feb 2, 2026

Uh oh!

victoralmau left a comment

Uh oh!

mariancuadranetkia commented Feb 20, 2026

Uh oh!

eduezerouali-tecnativa commented Mar 4, 2026

Uh oh!

eduezerouali-tecnativa commented Mar 4, 2026

Uh oh!

mariancuadranetkia commented Mar 5, 2026

Uh oh!

eduezerouali-tecnativa commented Mar 5, 2026

Uh oh!

mariancuadranetkia commented Mar 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

Uh oh!

Conversation

eduezerouali-tecnativa commented Jan 15, 2026

Uh oh!

victoralmau Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

pedrobaeza commented Feb 2, 2026

Uh oh!

victoralmau left a comment

Choose a reason for hiding this comment

Uh oh!

mariancuadranetkia commented Feb 20, 2026

Uh oh!

eduezerouali-tecnativa commented Mar 4, 2026

Uh oh!

eduezerouali-tecnativa commented Mar 4, 2026

Uh oh!

mariancuadranetkia commented Mar 5, 2026

Uh oh!

eduezerouali-tecnativa commented Mar 5, 2026

Uh oh!

mariancuadranetkia commented Mar 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants