Skip to content

[17.0][ADD] sale_partner_operating_unit#750

Open
yankinmax wants to merge 1 commit intoOCA:17.0from
camptocamp:add-sale_partner_operating_unit
Open

[17.0][ADD] sale_partner_operating_unit#750
yankinmax wants to merge 1 commit intoOCA:17.0from
camptocamp:add-sale_partner_operating_unit

Conversation

@yankinmax
Copy link

No description provided.

@yankinmax yankinmax force-pushed the add-sale_partner_operating_unit branch 2 times, most recently from 7b197ea to cc77cb3 Compare March 11, 2025 08:00
Copy link

@SilvioC2C SilvioC2C left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is red

Comment on lines +16 to +17
and order.partner_id.operating_unit_ids
and (len(order.partner_id.operating_unit_ids) == 1)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove the and order.partner_id.operating_unit_ids condition: it's implicitly checked by the count of them (if there's no partner, or no OU on the partner, then len(order.partner_id.operating_unit_ids) will be 0).

@yankinmax yankinmax force-pushed the add-sale_partner_operating_unit branch from cc77cb3 to 9e78f48 Compare March 13, 2025 11:46
@yankinmax yankinmax force-pushed the add-sale_partner_operating_unit branch from 9e78f48 to ba1f267 Compare March 13, 2025 12:02
@yankinmax
Copy link
Author

The test is failing due to an issue related to the sale_operating_unit module.

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 13, 2025
@github-actions github-actions bot closed this Aug 17, 2025
@vvrossem
Copy link
Contributor

@OCA/accounting-maintainers could you please reopen this PR and apply the "no stale" label ? 🤗

@AaronHForgeFlow AaronHForgeFlow added no stale Use this label to prevent the automated stale action from closing this PR/Issue. and removed stale PR/Issue without recent activity, it'll be soon closed automatically. labels Mar 12, 2026
@yankinmax yankinmax force-pushed the add-sale_partner_operating_unit branch from 3dc1160 to ba1f267 Compare March 12, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved no stale Use this label to prevent the automated stale action from closing this PR/Issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants