[18.0][FIX] edi_storage_oca: add event listener#226
[18.0][FIX] edi_storage_oca: add event listener#226ArnauCForgeFlow wants to merge 1 commit intoOCA:18.0from
Conversation
LoisRForgeFlow
left a comment
There was a problem hiding this comment.
Can you add a test case to avoid regressions again?
ed161b3 to
6514a45
Compare
| "website": "https://github.com/OCA/edi-framework", | ||
| "author": "ACSONE,Odoo Community Association (OCA)", | ||
| "depends": ["edi_core_oca", "fs_storage"], | ||
| "depends": ["edi_core_oca", "fs_storage", "edi_component_oca"], |
There was a problem hiding this comment.
@etobella Could we ask for your opinion here? there was a regression, but to revert it we need a new dependency... not sure if you would prefer this in a glue module. Thoughts?
6514a45 to
652524c
Compare
652524c to
6ecf880
Compare
|
@LoisRForgeFlow tests added |
etobella
left a comment
There was a problem hiding this comment.
If you need a component, you should add a new module (glue module)
|
Silly question, can you get the same result without components? |
|
I am using this module together with document_quick_access_folder_auto_classification, which is responsible for processing the file. I added the listener to the edi_storage_oca module because I understand it to be a generic behavior that should be used for all records that use the edi_storage_oca backend. It works because the document_quick_access_folder_auto_classification module adds edi_component_oca, so I assume that the listener does not work on its own unless the component dependency is added. |
|
Yes, but that's because I did not had the time to remove the dependency 😉 |
|
So, your suggestion is create a glue module with the listenner and the component dependency? |
|
my suggestion would be: 1- Can we do it without components? If yes, do it |
|
Short term, I would:
Long term, this makes me think that we should probably have an explicit handler for state transition on the type.
Opinions? |
During the migration of edi_storage_oca to the new EDI version, the listener that executes once the EDI record has been processed was omitted.