Skip to content

[16.0][FIX] base_bank_from_iban: Add new except to _get_bank_from_iban#261

Merged
OCA-git-bot merged 1 commit intoOCA:16.0from
Tecnativa:16.0-fix-base_bank_from_iban-error
Feb 18, 2026
Merged

[16.0][FIX] base_bank_from_iban: Add new except to _get_bank_from_iban#261
OCA-git-bot merged 1 commit intoOCA:16.0from
Tecnativa:16.0-fix-base_bank_from_iban-error

Conversation

@Andrii9090-tecnativa
Copy link
Contributor

@Andrii9090-tecnativa Andrii9090-tecnativa commented Feb 18, 2026

To avoid errors, we must add exceptions to the _get_bank_from_iban method of the res.partner.bank model.

File "/opt/odoo/auto/addons/account_payment_partner/tests/test_account_payment_partner.py", line 523, in test_refund_no_payment_mode_preserves_partner_bank
    trusted_bank = self.env["res.partner.bank"].create(
  File "<decorator-gen-782>", line 2, in create
  File "/opt/odoo/custom/src/odoo/odoo/api.py", line 430, in _model_create_multi
    return create(self, [arg])
  File "/opt/odoo/auto/addons/base_bank_from_iban/models/res_partner_bank.py", line 21, in create
    vals_list = [self._add_bank_vals(vals) for vals in vals_list]
  File "/opt/odoo/auto/addons/base_bank_from_iban/models/res_partner_bank.py", line 21, in <listcomp>
    vals_list = [self._add_bank_vals(vals) for vals in vals_list]
  File "/opt/odoo/auto/addons/base_bank_from_iban/models/res_partner_bank.py", line 30, in _add_bank_vals
    vals["bank_id"] = self._get_bank_from_iban(vals["acc_number"]).id
  File "/opt/odoo/auto/addons/base_bank_from_iban/models/res_partner_bank.py", line 36, in _get_bank_from_iban
    iban = schwifty.IBAN(acc_number)
  File "/usr/local/lib/python3.10/site-packages/schwifty/iban.py", line 77, in __init__
    self.validate(validate_bban)
  File "/usr/local/lib/python3.10/site-packages/schwifty/iban.py", line 178, in validate
    self._validate_iban_checksum()
  File "/usr/local/lib/python3.10/site-packages/schwifty/iban.py", line 202, in _validate_iban_checksum
    raise exceptions.InvalidChecksumDigits("Invalid checksum digits")
schwifty.exceptions.InvalidChecksumDigits: Invalid checksum digits

@pedrobaeza can you review?
@Tecnativa

@pedrobaeza pedrobaeza added this to the 16.0 milestone Feb 18, 2026
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

Fast-tracking this obvious one:

/ocabot merge patch

Please fw-port it

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-261-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 654ff86 into OCA:16.0 Feb 18, 2026
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c4dec92. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants