Skip to content

[19.0][MIG] l10n_eu_product_adr: Migration to 19.0#258

Open
yankinmax wants to merge 23 commits intoOCA:19.0from
camptocamp:19.0-mig-l10n_eu_product_adr
Open

[19.0][MIG] l10n_eu_product_adr: Migration to 19.0#258
yankinmax wants to merge 23 commits intoOCA:19.0from
camptocamp:19.0-mig-l10n_eu_product_adr

Conversation

@yankinmax
Copy link

No description provided.

Copy link
Member

@mmequignon mmequignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, will test on runboat later

Copy link

@rrebollo rrebollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review: Great work! The code looks good to me (LGTM). Thank you for your contribution! I've provided a few suggestions for your consideration—feel free to address them as you see fit.

@rrebollo
Copy link

@yankinmax would you be so kind to review mine back? #232

@geraldaistleitner
Copy link

Is there anything I can help with, would need the modules already for a customer? @yankinmax

@rrebollo
Copy link

@geraldaistleitner you could make a technical or functional review.

@yankinmax
Copy link
Author

@yankinmax would you be so kind to review mine back? #232

hello @rrebollo , I'll drop a review soon, thanks. Sorry for not answering here, was on a long vacation.

Copy link

@Camille0907 Camille0907 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migration LGTM, thank you 🙂

else:
# Conflate the reference unit (kilo, liter) with the ADR unit
reference_qty = sm.product_uom_qty / sm.product_uom.factor
# import pdb; pdb.set_trace()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# import pdb; pdb.set_trace()

debug leftover ? 😉

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

chaule97 and others added 9 commits January 28, 2026 09:53
Currently translated at 40.3% (947 of 2347 strings)

Translation: community-data-files-18.0/community-data-files-18.0-l10n_eu_product_adr
Translate-URL: https://translation.odoo-community.org/projects/community-data-files-18-0/community-data-files-18-0-l10n_eu_product_adr/it/
Currently translated at 44.5% (1046 of 2346 strings)

Translation: community-data-files-18.0/community-data-files-18.0-l10n_eu_product_adr
Translate-URL: https://translation.odoo-community.org/projects/community-data-files-18-0/community-data-files-18-0-l10n_eu_product_adr/it/
Currently translated at 93.9% (2205 of 2346 strings)

Translation: community-data-files-18.0/community-data-files-18.0-l10n_eu_product_adr
Translate-URL: https://translation.odoo-community.org/projects/community-data-files-18-0/community-data-files-18-0-l10n_eu_product_adr/fr/
Currently translated at 78.6% (1846 of 2346 strings)

Translation: community-data-files-18.0/community-data-files-18.0-l10n_eu_product_adr
Translate-URL: https://translation.odoo-community.org/projects/community-data-files-18-0/community-data-files-18-0-l10n_eu_product_adr/it/
@yankinmax yankinmax force-pushed the 19.0-mig-l10n_eu_product_adr branch from b0cbae0 to bf58e4b Compare January 28, 2026 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.