[19.0][MIG] l10n_eu_product_adr: Migration to 19.0#258
[19.0][MIG] l10n_eu_product_adr: Migration to 19.0#258
Conversation
mmequignon
left a comment
mmequignon
left a comment
There was a problem hiding this comment.
Code looks good, will test on runboat later
rrebollo
left a comment
rrebollo
left a comment
There was a problem hiding this comment.
Code Review: Great work! The code looks good to me (LGTM). Thank you for your contribution! I've provided a few suggestions for your consideration—feel free to address them as you see fit.
|
@yankinmax would you be so kind to review mine back? #232 |
|
Is there anything I can help with, would need the modules already for a customer? @yankinmax |
|
@geraldaistleitner you could make a technical or functional review. |
hello @rrebollo , I'll drop a review soon, thanks. Sorry for not answering here, was on a long vacation. |
yankinmax
force-pushed
the
19.0-mig-l10n_eu_product_adr
branch
from
8c6bc3c to
b0cbae0
Compare
| else: | ||
| # Conflate the reference unit (kilo, liter) with the ADR unit | ||
| reference_qty = sm.product_uom_qty / sm.product_uom.factor | ||
| # import pdb; pdb.set_trace() |
There was a problem hiding this comment.
| # import pdb; pdb.set_trace() |
debug leftover ? 😉
|
This PR has the |
Co-authored-by: Iryna Vyshnevska <iryna.vyshnevska@camptocamp.com>
Currently translated at 40.3% (947 of 2347 strings) Translation: community-data-files-18.0/community-data-files-18.0-l10n_eu_product_adr Translate-URL: https://translation.odoo-community.org/projects/community-data-files-18-0/community-data-files-18-0-l10n_eu_product_adr/it/
Currently translated at 44.5% (1046 of 2346 strings) Translation: community-data-files-18.0/community-data-files-18.0-l10n_eu_product_adr Translate-URL: https://translation.odoo-community.org/projects/community-data-files-18-0/community-data-files-18-0-l10n_eu_product_adr/it/
Currently translated at 93.9% (2205 of 2346 strings) Translation: community-data-files-18.0/community-data-files-18.0-l10n_eu_product_adr Translate-URL: https://translation.odoo-community.org/projects/community-data-files-18-0/community-data-files-18-0-l10n_eu_product_adr/fr/
Currently translated at 78.6% (1846 of 2346 strings) Translation: community-data-files-18.0/community-data-files-18.0-l10n_eu_product_adr Translate-URL: https://translation.odoo-community.org/projects/community-data-files-18-0/community-data-files-18-0-l10n_eu_product_adr/it/
yankinmax
force-pushed
the
19.0-mig-l10n_eu_product_adr
branch
from
b0cbae0 to
bf58e4b
Compare
14 participants
No description provided.