Open
Conversation
hbrunn
approved these changes
Mar 9, 2026
Member
hbrunn
left a comment
hbrunn
left a comment
There was a problem hiding this comment.
big diff is caused by OCA/server-tools#3535
Now seeing it however, I wonder if we should add yet another change to update_analysis to not add the eval attribute if it's '', because that's exactly what would be written without it anyways?
Member
|
Yes, I think it's the moment to refine it. |
Member
|
done in OCA/server-tools#3541 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Analysis or noupdate changes for modules marked as done: