Fix posix_cond_timedwait return value#1060
Open
Algafix wants to merge 1 commit into
Open
Conversation
|
Thanks for the fix @Algafix ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the bladeRF-cli I saw that the tx/rx wait Xs command was not returning.
After further inspection, I believe it is because
posix_cond_timedwait()is returning -1 instead ofETIMEDOUT.In the bladeRF-cli code, the comparison is done with
THREAD_TIMEOUT, which is mapped toETIMEDOUT.At a quick look, I have not seen any part of the codebase where the comparison is with -1 instead of
THREAD_TIMEOUTor similar. I might be wrong, then the change should be in the bladeRF-cli code to compare with -1.#1025