[deps] Upgrade vllm-router and fix 0.1.15 startup - #1988
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the vllm-router dependency to the official 0.1.15 release across the skyrl-train, fsdp, and megatron dependency groups in pyproject.toml. It also removes the temporary custom wheel definitions that were previously used as a workaround. There are no review comments, and I have no feedback to provide.
a37ae76 to
df10863
Compare
Signed-off-by: Bruno Volpato <brunocvcunha@gmail.com>
df10863 to
a97c8e0
Compare
|
@bvolpato the custom wheel we're using also has our custom load aware router policy So we can't simply upgrade to vllm-router 0.1.15 directly . Let me make an issue to track the upgrade though - we should move to a custom wheel on top of 0.1.15 for now. |
|
Created an issue to track #2070 |
|
Makes sense! Thanks @SumanthRH |
Summary
Replace temporary
vllm-router==0.1.14.post1custom wheels with officialvllm-router==0.1.15across SkyRL training, FSDP, and Megatron extras.Version 0.1.15 includes the custom wheel's load-aware routing fix, publishes x86_64 and aarch64 wheels, and removes the old
pd_disaggregationRouterArgsfield. SkyRL's fallback access to that removed field crashed regular, non-PD startup after the router became healthy.Changes
vllm-router==0.1.15and refresh the lockfile.vllm_pd_disaggregationfield directly./inference/v1/generateendpoint through router configuration.Testing
10 passed)RouterArgsvllm-router==0.1.15uv lock --checkgit diff --check