Skip to content

[deps] Upgrade vllm-router and fix 0.1.15 startup - #1988

Closed
bvolpato wants to merge 2 commits into
NovaSky-AI:mainfrom
bvolpato:bvolpato/router-load-aware-skyrl
Closed

[deps] Upgrade vllm-router and fix 0.1.15 startup#1988
bvolpato wants to merge 2 commits into
NovaSky-AI:mainfrom
bvolpato:bvolpato/router-load-aware-skyrl

Conversation

@bvolpato

@bvolpato bvolpato commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Summary

Replace temporary vllm-router==0.1.14.post1 custom wheels with official vllm-router==0.1.15 across SkyRL training, FSDP, and Megatron extras.

Version 0.1.15 includes the custom wheel's load-aware routing fix, publishes x86_64 and aarch64 wheels, and removes the old pd_disaggregation RouterArgs field. SkyRL's fallback access to that removed field crashed regular, non-PD startup after the router became healthy.

Changes

  • Pin official vllm-router==0.1.15 and refresh the lockfile.
  • Use the 0.1.15 vllm_pd_disaggregation field directly.
  • Register SkyRL's typed /inference/v1/generate endpoint through router configuration.
  • Cover regular and prefill/decode startup arguments.

Testing

  • Router tests (10 passed)
  • Direct construction of regular cache-aware and prefill/decode RouterArgs
  • Direct import of official vllm-router==0.1.15
  • uv lock --check
  • Ruff, Black, Gitleaks, and git diff --check
  • Lockfile contains official manylinux x86_64 and aarch64 wheels

@bvolpato
bvolpato marked this pull request as ready for review August 5, 2026 18:15

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the vllm-router dependency to the official 0.1.15 release across the skyrl-train, fsdp, and megatron dependency groups in pyproject.toml. It also removes the temporary custom wheel definitions that were previously used as a workaround. There are no review comments, and I have no feedback to provide.

@bvolpato bvolpato changed the title [deps] Upgrade vllm-router to 0.1.15 [deps] Upgrade vllm-router and fix 0.1.15 startup Aug 5, 2026
@bvolpato
bvolpato force-pushed the bvolpato/router-load-aware-skyrl branch 2 times, most recently from a37ae76 to df10863 Compare August 14, 2026 04:39
@bvolpato
bvolpato force-pushed the bvolpato/router-load-aware-skyrl branch from df10863 to a97c8e0 Compare August 16, 2026 15:20
@SumanthRH

SumanthRH commented Aug 19, 2026

Copy link
Copy Markdown
Member

@bvolpato the custom wheel we're using also has our custom load aware router policy sticky_least_loaded: vllm-project/router@main...SumanthRH:router:sticky_least_loaded

So we can't simply upgrade to vllm-router 0.1.15 directly .

Let me make an issue to track the upgrade though - we should move to a custom wheel on top of 0.1.15 for now.

@SumanthRH

Copy link
Copy Markdown
Member

Created an issue to track #2070

@SumanthRH SumanthRH closed this Aug 19, 2026
@bvolpato

Copy link
Copy Markdown
Contributor Author

Makes sense! Thanks @SumanthRH

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants