fix(acls): replace UUID type with str for improved compatibility#85
Open
briansumma wants to merge 4 commits intoNorthShoreAutomation:mainfrom
Open
fix(acls): replace UUID type with str for improved compatibility#85briansumma wants to merge 4 commits intoNorthShoreAutomation:mainfrom
briansumma wants to merge 4 commits intoNorthShoreAutomation:mainfrom
Conversation
Add complete ACLs API integration providing access control management features. Key additions: - AclsSpec with comprehensive permission management methods - Pydantic models for ACL request/response handling - Internal utilities for Pydantic model detection - Extensive test coverage for ACLs functionality
Update ACLs models and specs to use string type instead of UUID for all identifiers. This change ensures better compatibility with existing models and aligns with user expectations when calling API methods.
Member
|
nice! mind updating to use list_ instead of fetch when getting a list of objects? Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I'd like to update my existing PR "feat(acls): implement ACLs API functionality" with the following changes:
Changes in this update
UUIDtype references withstrin model field definitionsImplementation details
After additional testing with the API, I discovered that using Python's
UUIDtype directly caused compatibility issues with:This change simplifies the type system and avoids unnecessary conversions between UUID and string types. The implementation maintains all the same functionality but improves usability and robustness when dealing with identifiers from various sources.
Testing
All existing tests have been updated to reflect the type changes and continue to pass. The tests demonstrate proper handling of string identifiers throughout the ACLs functionality.
This change has no impact on the API's behavior - it's purely a type system improvement to match user expectations and simplify integration.