-
Notifications
You must be signed in to change notification settings - Fork 49
feat(vis-network): use scanner extractors #598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(vis-network): use scanner extractors #598
Conversation
91f81ef to
33c58a1
Compare
b55b601 to
3ce4720
Compare
3ce4720 to
a336a5e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #598 +/- ##
============================================
- Coverage 100.00% 56.47% -43.53%
============================================
Files 15 43 +28
Lines 649 3377 +2728
Branches 0 14 +14
============================================
+ Hits 649 1907 +1258
- Misses 0 1470 +1470 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a336a5e to
dde30e3
Compare
| assert.equal(nsDataSet.prettySize, "1.34 kB", "should convert bytes to human readable string"); | ||
| }); | ||
|
|
||
| test("NodeSecureDataSet.computeExtensions", () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can test the extensions and licenses computations through the init methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been removed because computation is already tested in scanner payload tests. Is it relevent to test them again as class properties ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess yes, since you want to be sure that you've done the extraction when you call the init method
GOAL
use scanner extractors to get manifest info to show in UI instead of computing scanner results again.
Relates to
NodeSecure/scanner#307
To do / Propositions
improve scanner warnings extractor:
add parameter to filter unwanted warnings
improve scanner contacts extractor:
add publishers to the list ?
current issues / need advices
get node built in to work on browser platform: