labrador: init at 0-unstable-2026-01-05#477199
labrador: init at 0-unstable-2026-01-05#477199randomizedcoder wants to merge 1 commit intoNixOS:masterfrom
Conversation
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/6238 |
pkgs/by-name/la/labrador/package.nix
Outdated
| ''; | ||
| homepage = "https://github.com/espotek-org/Labrador"; | ||
| license = lib.licenses.gpl3Only; | ||
| # maintainers = with lib.maintainers; [ randomizedcoder ]; |
There was a problem hiding this comment.
| # maintainers = with lib.maintainers; [ randomizedcoder ]; | |
| maintainers = with lib.maintainers; [ randomizedcoder ]; |
There was a problem hiding this comment.
Sorry, my github name hasn't landed in https://github.com/NixOS/nixpkgs/blob/master/maintainers/maintainer-list.nix yet. Once it does, I can add this line. ( Speaking of which, this maintainer-list.nix is very large. I wonder if it should be split by subdirs "aa" ... ? )
There was a problem hiding this comment.
Just add yourself to that list. I don't think there are currently plans to split that file.
|
@SuperSandro2000 Thanks for the review. - In general, if I want to document how a package.nix is setup, and why, what's the best way please? Could I make a README.md in the folder? The reason I ask is that I'm working on packaging Performance Co Pilot ( https://github.com/performancecopilot/pcp ) and it's a bit of a nightmare. Anyone coming back to look in a couple of months will be very confused. |
2f9db0e to
e14b0c1
Compare
|
Good idea about the udev rule. Updated, and fixed the commits (doh!) Labrador now also has flake.nix |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/6430 |
I would add comments to key lines that are not very intuitive and raise questions. |
pkgs/by-name/la/labrador/package.nix
Outdated
| ''; | ||
| homepage = "https://github.com/espotek-org/Labrador"; | ||
| license = lib.licenses.gpl3Only; | ||
| # maintainers = with lib.maintainers; [ randomizedcoder ]; |
There was a problem hiding this comment.
| # maintainers = with lib.maintainers; [ randomizedcoder ]; | |
| maintainers = with lib.maintainers; [ randomizedcoder ]; |
other bits are looking good
|
Thanks again. I made the mistake of including randomizedcoder maintainer into this PR, which I just fixed up |
|
@SuperSandro2000 ... And I also think we need some commit hooks for run nix fmt - I assume this has come up before, so I'm not sure why it didn't make progress |
|
Please rebase in a few minutes when the other PR is merged. |
I don't know, I don't use commit hooks as they interfere when rebasing when not done correct. |
e14b0c1 to
b6a3021
Compare
|
Closing and reopening to fix CI, see #499751 |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
b6a3021 to
7e039ff
Compare
|
Addressed @SuperSandro2000's review feedback, rebased, and squashed into a single commit. Changes applied:
|
Summary
Add EspoTek Labrador - an open-source USB device that turns your PC into a full-featured electronics lab bench with oscilloscope, signal generator, logic analyzer, and multimeter functionality.
This package builds the Qt5 desktop application for interfacing with the Labrador hardware.
Features
udev rules (Linux)
For non-root USB access, users need to add udev rules. On NixOS:
Build verification
Application launches successfully and scans for USB device (expected "DEVICE NOT FOUND" without hardware connected).
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.