php.extensions.smbclient: init at 1.0.4

[aanderse]

Motivation for this change

I'm probably going to need this at some point. I also have a sneaking suspicion that nextcloud could make use of this.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[SuperSandro2000]

Suggested change

	{ buildPecl, lib, pkgs }:
	{ buildPecl, lib, samba, pkg-config }:

[aanderse]

@etu @talyz @Ma27 did we want to switch all the php packages and extensions over to this style?

[etu]

Well, we could, but maybe not worth to change all packages and extensions in this PR. It's more commonly used across nixpkgs so it would be nice to follow that.

[aanderse]

Great. I'll write up a PR once I get a chance. Thanks!

[SuperSandro2000]

Overwriting packages is not that easy when they are used indirectly.

[SuperSandro2000]

Suggested change

	LIBSMBCLIENT_INCDIR = "${pkgs.samba.dev}/include/samba-4.0";
	LIBSMBCLIENT_INCDIR = "${samba.dev}/include/samba-4.0";

[SuperSandro2000]

Suggested change

	nativeBuildInputs = [ pkgs.pkg-config ];
	buildInputs = [ pkgs.samba.dev ];
	nativeBuildInputs = [ pkg-config ];
	buildInputs = [ samba.dev ];

[jtojnar]

Also should just be samba, since we want a library here. (Though it will work either way because inputs ignore the derivation outputs.

[SuperSandro2000]

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111515 run on x86_64-linux 1

3 packages built:

• php73Extensions.smbclient
• phpExtensions.smbclient (php74Extensions.smbclient)
• php80Extensions.smbclient