tests/functional: Output an actually correct command to accept test c… #14516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hanges I've run into this quite a few times when working with characterization test infra. It would print an invalid command: _NIX_TEST_ACCEPT=1 meson test main/lang Which you'd then proceed to run and it would fail. This commit makes it be honest about the command you need to run: _NIX_TEST_ACCEPT=1 meson test --suite main lang
github-actions
bot
added
the
with-tests
Ericson2314
approved these changes
Nov 9, 2025
Member
|
Nice catch :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…hanges
Motivation
I've run into this quite a few times when working with characterization test infra. It would print an invalid command:
Which you'd then proceed to run and it would fail. This commit makes it be honest about the command you need to run:
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.