-
-
Couldn't load subscription status.
- Fork 142
Adds 'orientation' field to Result #236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Adds 'orientation' field to Result #236
Conversation
…ency & auto-linking fix This commit introduces comprehensive improvements to the React Native Multiple Image Picker library: 🔧 Auto-linking Fix for Android: - Fixed broken prefab dependency resolution for react-native-nitro-modules - Implemented manual NitroModules linking to bypass prefab issues - Added dynamic library path discovery with multiple fallback locations - Enhanced CMake configuration with comprehensive error handling and logging 🖼️ Orientation Handling for Android: - Automatic EXIF orientation processing to ensure images display correctly - Dimension adjustment based on orientation (width/height swapping for 90°/270° rotations) - Comprehensive error handling for corrupted EXIF data and memory issues - Performance-optimized one-at-a-time processing to prevent memory exhaustion 📱 Cross-Platform realPath Consistency: - iOS now populates realPath with the actual file path (without "file://" prefix) - Android maintains existing behavior with real file system paths - Consistent API allowing developers to reliably use realPath on both platforms 📝 Documentation & Testing: - Comprehensive documentation in docs/ORIENTATION.md - Unit tests for orientation handling (OrientationTest.kt) - Updated TypeScript interfaces with proper platform annotations 🚨 Breaking Changes: None - All changes are backward compatible Closes NitrogenZLab#236
edf2554 to
a7d1e28
Compare
|
All looks good to me, the lib is working on Android and iOS in my React-Native 0.76 application. Could you please @baronha review this PR and add your comments? |
…ency & auto-linking fix This commit introduces comprehensive improvements to the React Native Multiple Image Picker library: 🔧 Auto-linking Fix for Android: - Fixed broken prefab dependency resolution for react-native-nitro-modules - Implemented manual NitroModules linking to bypass prefab issues - Added dynamic library path discovery with multiple fallback locations - Enhanced CMake configuration with comprehensive error handling and logging 🖼️ Orientation Handling for Android: - Automatic EXIF orientation processing to ensure images display correctly - Dimension adjustment based on orientation (width/height swapping for 90°/270° rotations) - Comprehensive error handling for corrupted EXIF data and memory issues - Performance-optimized one-at-a-time processing to prevent memory exhaustion 📱 Cross-Platform realPath Consistency: - iOS now populates realPath with the actual file path (without "file://" prefix) - Android maintains existing behavior with real file system paths - Consistent API allowing developers to reliably use realPath on both platforms 📝 Documentation & Testing: - Comprehensive documentation in docs/ORIENTATION.md - Unit tests for orientation handling (OrientationTest.kt) - Updated TypeScript interfaces with proper platform annotations 🚨 Breaking Changes: None - All changes are backward compatible Closes NitrogenZLab#236
bf0b921 to
1c3c5b9
Compare
|
I did a fix on the autolinking code so that it works for Debug and Release build artifacts. |
|
Thank you for your effort, I will take a look, man @zedtux |
…ency & auto-linking fix This commit introduces comprehensive improvements to the React Native Multiple Image Picker library: 🔧 Auto-linking Fix for Android: - Fixed broken prefab dependency resolution for react-native-nitro-modules - Implemented manual NitroModules linking to bypass prefab issues - Added dynamic library path discovery with multiple fallback locations - Enhanced CMake configuration with comprehensive error handling and logging 🖼️ Orientation Handling for Android: - Automatic EXIF orientation processing to ensure images display correctly - Dimension adjustment based on orientation (width/height swapping for 90°/270° rotations) - Comprehensive error handling for corrupted EXIF data and memory issues - Performance-optimized one-at-a-time processing to prevent memory exhaustion 📱 Cross-Platform realPath Consistency: - iOS now populates realPath with the actual file path (without "file://" prefix) - Android maintains existing behavior with real file system paths - Consistent API allowing developers to reliably use realPath on both platforms 📝 Documentation & Testing: - Comprehensive documentation in docs/ORIENTATION.md - Unit tests for orientation handling (OrientationTest.kt) - Updated TypeScript interfaces with proper platform annotations 🚨 Breaking Changes: None - All changes are backward compatible Closes NitrogenZLab#236
1c3c5b9 to
439f903
Compare
🚀 Implement Orientation Handling, Cross-Platform Real Path Consistency & Auto-linking Fix
📋 Overview
This pull request introduces enhanced orientation handling to the React Native Multiple Image Picker library, ensures cross-platform consistency by implementing
realPathon iOS, and fixes critical auto-linking issues that were preventing proper library compilation.✨ Key Changes
🔧 Auto-linking Fix for Android
react-native-nitro-modulesTechnical Details:
file(GLOB)to dynamically find NitroModules library across build variants🖼️ Orientation Handling for Android
Supported EXIF Orientations:
📱 Cross-Platform
realPathConsistencyrealPathwith the actual file path (without "file://" prefix)realPathon both platforms📝 Documentation & Testing
docs/ORIENTATION.mdOrientationTest.kt)🔨 Code Changes
iOS (
HybridMultipleImagePicker+Result.swift)Android (
MultipleImagePickerImp.kt)CMake Auto-linking (
MultipleImagePicker+autolinking.cmake)💡 Usage Examples
Accessing Orientation Data
Cross-Platform File Access
🎯 Benefits
For Developers
For Users
📊 Platform Support
realPathSupport🔍 Testing
🚨 Breaking Changes
None - All changes are backward compatible. Existing code will continue to work while new features are available as optional enhancements.
🎉 Conclusion
This pull request significantly improves the reliability and cross-platform consistency of the React Native Multiple Image Picker library. The auto-linking fix ensures smooth integration, while the orientation handling and
realPathconsistency provide developers with robust tools for handling media assets across platforms.Closes #235.