Update method fix - #85
Conversation
|
FYI you can reference a PR or issue by using the # sign. For example the issue mentioned is #84 |
|
|
||
| self.key_list = key_list | ||
|
|
||
| def add_data(self, new_data, new_key_names): |
There was a problem hiding this comment.
Doc strings in this would be appreciated. Please use the numpy doc string format.
|
Have you not written tests for this addition? |
|
Also it seems that the travis.yml file has some issues @tacaswell @danielballan have you seen these errors before? |
|
👍 , mostly agree with @CJ-Wright 's comments. The classes in this code are a bit out of control, I would not do them this way again if starting from scratch. It looks like much of this logic should fall back to the |
|
to fix the travis issue, change the channel from |
|
And if doing the messenger stuff 'right' turns into a complete hairball, I would lean on the side of just making this work. |
|
What's the status of this PR? |
As was brought up in the issue I created, there is currently no method for the CrossSectionMainWindow class. This pull request simply creates a method for this class to add new data to the cross section viewer.