Fix StarAgentSetting.OnLoaded overwriting user-cleared Services config with example entries#158
Merged
Merged
Conversation
…rst creation (IsNew)
Copilot
AI
changed the title
[WIP] Fix OnLoaded to prevent overriding user configurations with example services
Fix StarAgentSetting.OnLoaded overwriting user-cleared Services config with example entries
Jul 20, 2026
nnhy
marked this pull request as ready for review
July 20, 2026 15:01
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prevents StarAgentSetting.OnLoaded() from repopulating example Services entries after a user has intentionally cleared the services configuration, avoiding silent reintroduction of sample services on subsequent Save() calls (e.g., via WebPanel).
Changes:
- Gate example service population behind
IsNew, so sample services are only added on first-time config creation. - Ensure
Servicesis never leftnullafter load by initializing it to an empty array when appropriate.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StarAgentSetting.OnLoadedunconditionally populated 4 example services wheneverServiceswas null or empty, causing every subsequentSave()call (e.g. via WebPanel) to persist those examples — silently overwriting an intentionally empty user config.Changes
StarAgent/Setting.cs: Gate example-service population onIsNewso it only runs on first-time config creation, not on every load of an empty/cleared configServices ??= []in theelsebranch to ensureServicesis never null after loadFirst-run behavior (example services as reference) is preserved; existing configs with a cleared
<Services>node are left untouched.