Agent-compromise tests, Kani share-math proofs, WCAG 2.1 AA, and web push (#673 #672 #668 #669) - #721
Merged
Abidoyesimze merged 2 commits intoAug 27, 2026
Conversation
…push. Closes Neurowealth#673, Neurowealth#672, Neurowealth#668, and Neurowealth#669 by covering the agent blast radius on-chain, proving vault-favouring share accounting, bringing the vault UI to WCAG 2.1 AA with axe-core in CI, and adding batched Web Push plus email fallback. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep both the vault-ui accessibility job and the new frontend lint job from main. Co-authored-by: Cursor <cursoragent@cursor.com>
|
@josephchimebuka Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This was referenced Aug 28, 2026
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #673, #672, #668, and #669.
test_agent_compromise_scenarios.rstreats a stolen agent key as the attacker. Each scenario is its own test: owner-only calls (set_caps,transfer_ownership, caps/limits/TTL/timelock/migration/queue), withdrawing another user's funds, writing privileged storage, pause/unpause, WASM upgrade, pool retarget to a drain address, arbitraryTotalAssetsinflate/decrease, and deposit front-running. Allowed agent entry points (rebalance,submit_mev_report,submit_apy_prediction,process_withdrawal_queue) are covered to show they cannot steal shares. Threat-model table added toSECURITY.md.share-mathcrate (the contract calls the same helpers). Kani proofs cover:total_sharesequals the sum of user shares, no negative balances, exchange rate non-decreasing with yield, deposit/redeem round-trip never creates value, and rounding always favours the vault. Spec, CI job (kani-share-math), and maintenance process are indocs/FORMAL_VERIFICATION.md.aria-liveerrors,:focus-visible, AA contrast (gray-700/primary-700), rem-based type, chart data tables, axe-core via Vitest, anddocs/ACCESSIBILITY.md(including VoiceOver/NVDA checklist).docs/NOTIFICATIONS.md.Test plan
cargo test -p share-mathcargo test -p neurowealth-vault --lib test_agent_compromise./scripts/run-kani-proofs.sh(or CIkani-share-mathjob)cd packages/vault-ui && npm install && npm test(axe-core + notification unit tests)docs/ACCESSIBILITY.mdMade with Cursor