-
Notifications
You must be signed in to change notification settings - Fork 264
Update micromed for sampling issue #1701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@theairbend3r |
|
Tried this out but I still get the same ZeroDivisionError unfortunately |
|
Okay, I was hoping this would be the easy fix, but when I have time I'll try to read wonami more to see if they are doing some header parsing that we skip that could better account for different versions of the file format. |
|
Sounds good! Thanks for all your efforts, really appreciate it! :) |
|
@zm711 Potentially this request will provide test files for debugging here: wonambi-python/wonambi#42 |
|
just wanted to give you a small update. We discussed this at our maintenance meeting and our hope is to try to work on this for the next version of neo. As you can see from the link we put out the feelers to wonambi to see if they might have a test file that can reproduce the error so we can fix it. |
|
Appreciate the update @zm711! Hopefully, the test files help! 🤞 |
See #1696.
Testing to see if there is something wrong with class based approach @samuelgarcia maybe we could discuss this.