Bug fix vector_frames size in optical_flow.py#71
Open
FMarmoreo wants to merge 3 commits intoNeuralEnsemble:masterfrom
Open
Bug fix vector_frames size in optical_flow.py#71FMarmoreo wants to merge 3 commits intoNeuralEnsemble:masterfrom
FMarmoreo wants to merge 3 commits intoNeuralEnsemble:masterfrom
Conversation
…rors in smooth_frames function
rgutzen
requested changes
Jun 25, 2024
Collaborator
rgutzen
left a comment
rgutzen
left a comment
There was a problem hiding this comment.
Thanks for noting that the last vector frame is not calculated and filled. vector_frames should however keep the same dimensions as frames. So, instead the last frame could be explicitly filled with nan-values.
Contributor
|
@rgutzen why is it important for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix vector_frames size in optical_flow.py since the last frame of zeros in the initialization of vector_frames is not filled by the horn-schunck algorithm that runs in range frames[:-1]. This, in particular, introduces errors also in smooth_frames function.