ci(expb): record run dimensions in benchmark metrics#11485
Open
grubbyTimes wants to merge 1 commit intoNethermindEth:masterfrom
Open
ci(expb): record run dimensions in benchmark metrics#11485grubbyTimes wants to merge 1 commit intoNethermindEth:masterfrom
grubbyTimes wants to merge 1 commit intoNethermindEth:masterfrom
Conversation
`expb-metrics.env` now carries `BRANCH`, `CLEAN_BRANCH`, `SHA`, `STATE_LAYOUT`, `PAYLOAD_SET`, `DELAY_SECONDS`, `IMAGE`, `EXPB_VERSION`, plus run/scenario context — written by both single- and multi-image analyze steps before percentiles. `EXPB_VERSION` comes from `uv tool list` post-install. Existing `load_metric` consumers grep specific keys, so extra lines are ignored and master cache (`v3`) stays compatible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
expb-metrics.envnow carriesBRANCH,CLEAN_BRANCH,SHA,STATE_LAYOUT,PAYLOAD_SET,DELAY_SECONDS,IMAGE,EXPB_VERSION, plus run/scenario context — written by both single- and multi-image analyze steps before percentiles.EXPB_VERSIONcomes fromuv tool listpost-install. Existingload_metricconsumers grep specific keys, so extra lines are ignored and master cache (v3) stays compatible.