Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces an end-to-end test for the era export/import functionality and updates the NodeInfo helper to accommodate a new network type as well as refine the conversion logic for merge block numbers.
- Adds a comprehensive test (ExportImportTest) for era export and import, including log verifications and Docker container management.
- Introduces a new network type "Hoodi" and updates the conversion method in GetNetworkType.
Reviewed Changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| NethermindNode.Tests/Tests/HistoryExpiry/EraTests.cs | New integration test for era export/import functionality |
| NethermindNode.Core/Helpers/NodeInfo.cs | Updates to network type conversion and inclusion of a new network type |
Files not reviewed (2)
- NethermindNode.Tests/NethermindNode.Tests.csproj: Language not supported
- nethermind: Language not supported
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
brbrr
commented
May 1, 2025
Comment on lines
+228
to
+230
| case NetworkType.Sepolia: return 1000000; | ||
| case NetworkType.Hoodi: return 100000; | ||
| case NetworkType.Holesky: return 100000; |
Contributor
Author
There was a problem hiding this comment.
For the sake of speed - I decided to use relatively small number. probably we could update it to be more realistic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an import/export era test.
The test expects a node with FastSync/SnapSync flags enabled and AncientBarriers set to 0 (mostly for sepolia usecase defaults are bumped to post-merge)
The flow is quite simple: