Skip to content

Add a test which checks for proper finish of Bodies/Receipts on mutliple tries#28

Open
kamilchodola wants to merge 20 commits intomainfrom
kch/addReceiptsandBodiesCheck
Open

Add a test which checks for proper finish of Bodies/Receipts on mutliple tries#28
kamilchodola wants to merge 20 commits intomainfrom
kch/addReceiptsandBodiesCheck

Conversation

@kamilchodola
Copy link
Copy Markdown
Collaborator

As per description in test:

!!!!! Test to be used when NonValidator mode is true. !!!!!

1. Wait for node to be synced (eth_syncing returns false)
2. Stop a execution node
3. Create a backup of database
4. Restart node but without NonValidator node flags
5. Wait until end of sync (eth_syncing returns false)
6. Check if logs "Fast blocks bodies task completed." and "Fast blocks receipts task completed." are there - those two should always been present meaning that tasks are properly finished.
7. Stop a node, restore backup, redo steps 5 and 6

WHY?
If there is no such logs, there is high chance we "lost" something and we should investigate what is missing 

Copy link
Copy Markdown
Contributor

@brbrr brbrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides small naming nitpick - LGTM

DockerCommands.StopDockerContainer(ConfigurationHelper.Instance["execution-container-name"], Logger);

CommandExecutor.RemoveDirectory(execPath + "/nethermind_db", Logger);
CommandExecutor.BackupDirectory(execPath + "/nethermind_db_backup", execPath + "/nethermind_db", Logger);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably BackupDirectory is not the best name. Maybe CopyDirectory will work better?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants