Skip to content

Comments

bump to 4.26#4

Open
alexanderlhicks wants to merge 1 commit intoNethermindEth:masterfrom
alexanderlhicks:master
Open

bump to 4.26#4
alexanderlhicks wants to merge 1 commit intoNethermindEth:masterfrom
alexanderlhicks:master

Conversation

@alexanderlhicks
Copy link

A pain free bump to v4.26.0. This should help resolve the build issue in COmpPoly (Verified-zkEVM/CompPoly#4)

@dhsorens
Copy link

dhsorens commented Jan 9, 2026

Nice and easy!

Copy link
Collaborator

@Julek Julek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is quite broken, it seems batteries has introduced a bunch of theorems with names clashing with theorems in this library, not all of them match the statements, so some non-trivial work needs to be done here. Doesn't compile.

@alexanderlhicks
Copy link
Author

alexanderlhicks commented Jan 9, 2026

hmm interesting, it built fine locally 🤔

edit: nvm it does seem broken now, let me investigate.

@dhsorens
Copy link

dhsorens commented Jan 12, 2026

Investigating this. Proofs are easy to fix, there's just the question of what to do with the conflicting theorem names. The theorems in batteries etc seem to be simpler than the ones in this library but I'm not 100% sure how compatible they are or whether they're a simple, generalized replacement to the ones here. Options include:

  1. renaming the local clashing theorems with a _legacy or _temp suffix, or something with an aim to deprecate them
  2. rename the clashing theorems to make them more descriptive of the way they differ from the new standard theorems, with no (short-term) aim to deprecate

@alexanderlhicks @Julek I think the way to go may be number 2, it keeps the lemmas we have. We should probably go thru Arklib and CompPoly and edit the proofs to use the new mathlib theorems, and if we stop using any here completely we can deprecate.

@dhsorens
Copy link

see new PR #5 for proposed changes. in CompPoly and Arklib the best thing to do is probably try to adopt the new standard theorems/lemmas, but with these new more descriptive names we can also keep these theorems locally without needing to deprecate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants