Skip to content

feat(firewall): added device for SNATs #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tbaile merged 1 commit into from
May 28, 2025
Merged

feat(firewall): added device for SNATs #99

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/nethsec/firewall/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1752,7 +1752,7 @@ def list_nat_rules(uci) -> list:
rules.append(rule)
return rules

def add_nat_rule(uci, name: str, target: str, src: str = '*', src_ip: str = '', dest_ip: str = '', snat_ip: str = '') -> str:
def add_nat_rule(uci, name: str, target: str, src: str = '*', src_ip: str = '', dest_ip: str = '', snat_ip: str = '', device: str = '') -> str:
"""
Add nat rule to firewall config.

Expand All @@ -1764,6 +1764,7 @@ def add_nat_rule(uci, name: str, target: str, src: str = '*', src_ip: str = '',
src_ip: source ip
dest_ip: destination ip
snat_ip: snat ip
device: add nat rule just for specific device

Returns:
name of rule config that was added
Expand All @@ -1781,10 +1782,11 @@ def add_nat_rule(uci, name: str, target: str, src: str = '*', src_ip: str = '',
uci.set('firewall', rule, 'dest_ip', dest_ip)
uci.set('firewall', rule, 'snat_ip', snat_ip)
uci.set('firewall', rule, 'proto', ["all"])
uci.set('firewall', rule, 'device', device)
uci.save('firewall')
return rule

def edit_nat_rule(uci, id: str, name: str, target: str, src: str = '*', src_ip: str = '', dest_ip: str = '', snat_ip: str = '') -> str:
def edit_nat_rule(uci, id: str, name: str, target: str, src: str = '*', src_ip: str = '', dest_ip: str = '', snat_ip: str = '', device: str = '') -> str:
"""
Edit nat rule in firewall config.

Expand All @@ -1797,6 +1799,8 @@ def edit_nat_rule(uci, id: str, name: str, target: str, src: str = '*', src_ip:
src_ip: source ip
dest_ip: destination ip
snat_ip: snat ip
src_device: source device
device: add nat rule just for specific device

Returns:
name of rule config that was edited
Expand All @@ -1813,6 +1817,7 @@ def edit_nat_rule(uci, id: str, name: str, target: str, src: str = '*', src_ip:
uci.set('firewall', id, 'src_ip', src_ip)
uci.set('firewall', id, 'dest_ip', dest_ip)
uci.set('firewall', id, 'snat_ip', snat_ip)
uci.set('firewall', id, 'device', device)
uci.save('firewall')
return id

Expand Down