refactor: centralize module testing#79
Merged
Merged
Conversation
Agent-Logs-Url: https://github.com/NethServer/ns8-collabora/sessions/0dba9d0b-b450-4dbc-9eb7-c42b8c96c852 Co-authored-by: andre8244 <4612169+andre8244@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update testing infrastructure for ns8-collabora module
refactor: centralize module testing
Apr 24, 2026
Contributor
|
@copilot change |
Agent-Logs-Url: https://github.com/NethServer/ns8-collabora/sessions/62557c02-2c7a-4baf-bf26-b0cf6a5fef42 Co-authored-by: andre8244 <4612169+andre8244@users.noreply.github.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Centralizes the testing infrastructure to follow the standard conventions from NethServer/dev#7281, replacing the bespoke test runner setup with the shared
ns8-github-actions@v1workflow.Workflow
test-module.ymljobs with a singleuses: NethServer/ns8-github-actions/.github/workflows/test-module.yml@v1call, settingui_tests_strategy: alwaysRobot Framework tests
tests/collabora.robot→tests/10__collabora.robot; changeSet Suite Variable→Set Global Variablefor${module_id}so it propagates across test filestests/20__ui.robotusing the Browser library to screenshot the Status and Settings pages via the cluster-admin UIHousekeeping
tests/outputs/to.gitignoreREADME.mdwith a link to the ns8-github-actions v1 guidetest-module.shandtests/pythonreq.txtOriginal prompt
This PR centralizes the module testing infrastructure for ns8-collabora following the standard testing conventions established in NethServer/dev issue #7281 (NethServer/dev#7281).
Changes to perform:
Update
.github/workflows/test-module.yml: Replace with the centralized test module workflow from ns8-mail reference implementationui_tests_strategy: on_renovate_ui_changeAdd Robot Framework UI tests (since
ui/src/App.vueexists):tests/collabora.robotto add numeric prefix and changeSet Suite VariabletoSet Global Variablefor module_id variable to make it available to subsequent test filesUpdate testing configuration:
.gitignorecontainstests/outputs/entrytests/pythonreq.txtif presentReference Implementation:
All changes follow the pattern from NethServer/ns8-mail at commit d034d052cb0205da95a4947e2ccd4a20a031a1a9
The following is the prior conversation context from the user's chat exploration (may be truncated):
User: Create a PR for the following repositories:
PR title and commit message are "refactor: centralize module testing"
PR description is the following:
Ref:
The changes to perform are the following:
ui/src/App.vueexists, then add the robot file for ui tests by following these steps:output.module_idis available to subsequent test files by usingSet Global Variableinstead ofSet Suite Variable. Take note of the name of the file that installs the module, especially the starting number of its name. If the file name does not start with a number, then let's rename that file to 10__OLDNAME.robot; replace "OLDNAME" with the previous name of the fileNUMBER__ui.robotorNUMBER__ui.robot(check if existing robot files use one underscore or two in their name). Substitute "NUMBER" with an appropriate number, so that the ui tests are executed after the test that installs the module and before other tests. Example: if the module is installed inside "10__install.robot" and the next test is "20__test.robot", then name the ui tests file as "15__ui.robot". If it exists only one robot file called MODULENAME.robot and it does not have a numeric prefix, then rename it to10__MODULENAME.robotand use20__ui.robotfor the ui tests.MIDvariable to the one used inSet Global Variable; be sure to change all occurrences: the variable declaration to${EMPTY}AND the module variable used in theGo Toinstructionstests/outputs/Assistant: I'll create pull requests for both repositories with the specified changes. Let me start by gathering the necessary information and then create the PRs.
Assistant: Now let me fetch the reference materials for the robot file and README section:
Assistant: Now I need to get the tests directory structure and check for robot files, .gitignore, and other files for both repositories:
Assistant: Now let me get the test robot files to understand the structure:
Assistant: Now I'll create PRs for both repositories. I need to:
This pull request was created from Copilot chat.