fix(ipsec): reject curly braces in pre-shared keys#763
Merged
Conversation
gsanchietti
changed the title
m-dilorenzi
requested changes
May 14, 2026
andre8244
reviewed
May 14, 2026
Tbaile
approved these changes
May 14, 2026
Collaborator
Tbaile
left a comment
Tbaile
left a comment
There was a problem hiding this comment.
Aside from the escaping of the lang files and the ta lang changed (i have no clue on what to verify if it's actually legit), looking fine
gsanchietti
added a commit
that referenced
this pull request
May 14, 2026
- Add single quotes around escaped curly braces in tooltips for en and it translations - Refactor component to use NeTextInput label and tooltip props instead of separate components - Improve code readability and align with component best practices Fixes review comments on PR #763
gsanchietti
force-pushed
the
issue1631
branch
2 times, most recently
from
dfbabf6 to
6187c90
Compare
Reject unsupported curly brace characters in imported IPsec pre-shared keys and show a tooltip next to the field so users know which characters are not accepted. Add unit coverage for the new validation helper so this validation rule stays protected. Assisted-by: Copilot:gpt-5.4
m-dilorenzi
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject unsupported curly brace characters in imported IPsec pre-shared keys.
Add a tooltip next to the pre-shared key field so users know that
{and}are not accepted.
Cover the new validator with a focused unit test.
Related issue
NethServer/nethsecurity#1631
How to test
{or}and verify the form shows a validation error.that
{and}are not accepted.Dependencies
None