-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Preserve saved globals when copying DelayEvaluator #3346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Hashim1999164
wants to merge
2
commits into
Netflix:master
Choose a base branch
from
Hashim1999164:fix/delay-evaluator-copy-globals
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+77
−4
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| import copy | ||
|
|
||
| from metaflow.flowspec import FlowStateItems | ||
| from metaflow.parameters import current_flow | ||
| from metaflow.user_configs.config_parameters import DelayEvaluator | ||
|
|
||
|
|
||
| def _sample_globals(): | ||
| def my_func(): | ||
| return "hello" | ||
|
|
||
| return {"my_func": my_func} | ||
|
|
||
|
|
||
| class _DummyFlow: | ||
| _flow_state = {FlowStateItems.CONFIGS: {}} | ||
|
|
||
|
|
||
| def _with_dummy_flow(fn): | ||
| current_flow.flow_cls = _DummyFlow | ||
| try: | ||
| return fn() | ||
| finally: | ||
| del current_flow.flow_cls | ||
|
|
||
|
|
||
| def test_copy_preserves_saved_globals(): | ||
| saved = _sample_globals() | ||
| evaluator = DelayEvaluator("config", saved_globals=saved) | ||
| copied = copy.copy(evaluator) | ||
| assert copied._globals is saved | ||
| assert copied._globals["my_func"]() == "hello" | ||
|
|
||
|
|
||
| def test_deepcopy_preserves_saved_globals(): | ||
| saved = _sample_globals() | ||
| evaluator = DelayEvaluator("config", saved_globals=saved) | ||
| copied = copy.deepcopy(evaluator) | ||
| assert copied._globals is saved | ||
| assert copied._globals["my_func"]() == "hello" | ||
|
|
||
|
|
||
| def test_getattr_preserves_saved_globals(): | ||
| saved = _sample_globals() | ||
| evaluator = DelayEvaluator("config", saved_globals=saved) | ||
| chained = evaluator.project | ||
| assert chained._globals is saved | ||
| assert chained._access == ["project"] | ||
|
|
||
|
|
||
| def test_getitem_preserves_saved_globals(): | ||
| saved = _sample_globals() | ||
| evaluator = DelayEvaluator("config", saved_globals=saved) | ||
| chained = evaluator["project"] | ||
| assert chained._globals is saved | ||
| assert chained._access == ["project"] | ||
|
|
||
|
|
||
| def test_chained_call_uses_saved_globals(): | ||
| class _Cfg: | ||
| project = "from-globals" | ||
|
|
||
| saved = {"my_func": _Cfg} | ||
| evaluator = DelayEvaluator("my_func", saved_globals=saved) | ||
| chained = evaluator.project | ||
| assert _with_dummy_flow(chained) == "from-globals" | ||
|
|
||
|
|
||
| def test_copied_call_uses_saved_globals(): | ||
| saved = _sample_globals() | ||
| evaluator = DelayEvaluator("my_func()", saved_globals=saved) | ||
| copied = copy.copy(evaluator) | ||
| assert _with_dummy_flow(copied) == "hello" | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.