[Testing]Temp - #3175
Conversation
Greptile SummaryThis is a temporary testing PR with two minor devtools changes. The tiltfile refactor correctly inlines a constant (
Confidence Score: 5/5Safe to merge as a temporary devtools-only change; neither file touches runtime logic. Both changes are confined to the local development tooling (devtools/). The tiltfile simplification is a correct constant-folding with no observable effect, and the only other change is a meaningless comment. There is no impact on Metaflow runtime, production code, or tests. No files require special attention, though the placeholder Important Files Changed
Reviews (2): Last reviewed commit: "added hello" | Re-trigger Greptile |
There was a problem hiding this comment.
Pull request overview
This PR cleans up the Tilt configuration for running Step Functions Local by removing an unused hostNetwork toggle and hard-coding the Kubernetes pod networking settings to the existing behavior (no host networking).
Changes:
- Removes the unused
_sfn_host_networkvariable/assignments. - Sets
hostNetwork: FalseanddnsPolicy: ClusterFirstdirectly in the Deployment spec.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| 'hostNetwork': False, | ||
| 'dnsPolicy': 'ClusterFirst', |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3175 +/- ##
=========================================
Coverage ? 27.48%
=========================================
Files ? 376
Lines ? 51827
Branches ? 9166
=========================================
Hits ? 14246
Misses ? 36676
Partials ? 905 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
PR Type
Summary
Issue
Fixes #
Reproduction
Runtime:
Commands to run:
# paste exact commandsWhere evidence shows up:
Before (error / log snippet)
After (evidence that fix works)
Root Cause
Why This Fix Is Correct
Failure Modes Considered
Tests
Non-Goals
AI Tool Usage