Fix/multi inheritance #2639
Open
Fix/multi inheritance #2639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romain-intel
changed the base branch from
master
to
fix/support_editable_pkgs_more
romain-intel
force-pushed
the
fix/multi_inheritance
branch
from
ad214ed to
cc637df
Compare
Flow decorators were not properly merged in the case of multiple inheritance. For example: @project(name="foobar") class A(FlowSpec): pass class B(A): pass class C(B): pass Would result in the `project` decorator being included twice. This PR fixes this behavior and should support any arbitrary inheritance pattern. It also cleans up _flow_state (moving _flow_decorators into it) and fixes some other corner cases (I think). In particular, configs are now no longer merged as they are naturally inherited.
romain-intel
force-pushed
the
fix/multi_inheritance
branch
from
cc637df to
bd13ddf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.