Skip to content

[do not merge] check tests if CLICK_API_PROCESS_CONFIG is True #2572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[do not merge] check tests if CLICK_API_PROCESS_CONFIG is True #2572

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a5450f
Get tests to pass with the process config flag
romain-intel Oct 21, 2025
45df150
Merge branch 'master' into change-default-true-click-api-process-config
mt-ob Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion metaflow/metaflow_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,7 +546,7 @@
# Feature flag (experimental features that are *explicitly* unsupported)

# Process configs even when using the click_api for Runner/Deployer
CLICK_API_PROCESS_CONFIG = from_conf("CLICK_API_PROCESS_CONFIG", False)
CLICK_API_PROCESS_CONFIG = from_conf("CLICK_API_PROCESS_CONFIG", True)


# PINNED_CONDA_LIBS are the libraries that metaflow depends on for execution
Expand Down
30 changes: 26 additions & 4 deletions metaflow/runner/click_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,11 +474,22 @@ def _compute_flow_parameters(self):

ds = opts.get("datastore", defaults["datastore"])
quiet = opts.get("quiet", defaults["quiet"])

# Check for environment variables first

is_default = False
config_file = opts.get("config")
if config_file is None:
is_default = True
config_file = defaults.get("config")
# Check if it was set through an environment variable -- we
# don't have click process them here so we need to "fake" it.
env_config_file = os.environ.get("METAFLOW_FLOW_CONFIG")
if env_config_file:
# Convert dict items to list of tuples
config_file = list(json.loads(env_config_file).items())
is_default = False
else:
is_default = True
config_file = defaults.get("config")

if config_file:
config_file = dict(
Expand All @@ -494,8 +505,19 @@ def _compute_flow_parameters(self):
is_default = False
config_value = opts.get("config-value")
if config_value is None:
is_default = True
config_value = defaults.get("config_value")
env_config_value = os.environ.get("METAFLOW_FLOW_CONFIG_VALUE")
if env_config_value:
# Parse environment variable using MultipleTuple logic
loaded = json.loads(env_config_value)
# Convert dict items to list of tuples with JSON-serialized values
config_value = [
(k, json.dumps(v) if not isinstance(v, str) else v)
for k, v in loaded.items()
]
is_default = False
else:
is_default = True
config_value = defaults.get("config_value")

if config_value:
config_value = dict(
Expand Down
Loading