allow init cooldown to jobAutoScaler #811
Merged
+17
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andyz26
requested review from
calvin681,
dtrager02,
fdc-ntflx,
hellolittlej and
james-lubin
as code owners
Andyz26
requested a deployment
to
Integrate Pull Request
GitHub Actions
Waiting
Andyz26
requested a deployment
to
Integrate Pull Request
GitHub Actions
Waiting
hellolittlej
reviewed
Dec 2, 2025
Comment on lines
+546
to
+549
| boolean applyInitialCooldown = Boolean.parseBoolean( | ||
| Optional.ofNullable(MantisProperties.getProperty(SystemParameters.JOB_AUTOSCALE_APPLY_INITIAL_COOLDOWN_PARAM)) | ||
| .orElse("true")); | ||
| this.lastScaledAt = applyInitialCooldown ? System.currentTimeMillis() : 0L; |
Collaborator
There was a problem hiding this comment.
can you update description to add context of why do we need this cooldown at the init?
hellolittlej
approved these changes
Dec 2, 2025
james-lubin
approved these changes
Dec 2, 2025
|
|
||
| boolean applyInitialCooldown = Boolean.parseBoolean( | ||
| Optional.ofNullable(MantisProperties.getProperty(SystemParameters.JOB_AUTOSCALE_APPLY_INITIAL_COOLDOWN_PARAM)) | ||
| .orElse("true")); |
Collaborator
There was a problem hiding this comment.
Defaulting to true means we change the behavior for existing users, right?
Collaborator
Author
There was a problem hiding this comment.
yeah that's the intention and i don't think it should cause impact on regular jobs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users would like to have the scaler cooldown period applied when the job starts (especially when they use custom scaler rules to change the scaler config) to avoid a scaling decision made right after new scaler is created.