Allow swim up and swim down controls to move the player up and down the ladder#1802
Merged
AdamTadeusz merged 1 commit intoNeotokyoRebuild:masterfrom Mar 15, 2026
Conversation
sunzenshen
approved these changes
Mar 8, 2026
Contributor
There was a problem hiding this comment.
Tried this on a slightly tilted ladder and it feels alright as a human player.
(This was on a branch with the bots trying (unsuccessfully) to use these binds, but that will need some more work to get working. But that's out of scope for this PR.) [edit: ended up figuring out the bots in #1830]
I can't think of a reason why this would have a negative impact, so I'm all for it.
Contributor
|
Performed additional testing of the changes in the PR through working on #1830. Didn't need to modify these files to integrate with my PR, so at least these changes work for my use case. |
Rainyan
approved these changes
Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Mostly for bots which struggle to move straight up a ladder. When using these controls the direction of the player's camera is ignored when determining which way to move when on a ladder.
Toolchain