Repository navigation
Draw the compose sheet's Cancel and Commit as a cross and a check - #48
Merged
Merged
Conversation
The sheet's bar had a Cancel text button on glass and a Commit text button in your colour on iOS, text buttons on Android, and sat further from the top of the sheet than from its sides. Now Cancel is a cross and Commit a check, each in a 44pt circle, 16pt in from the top and sides on both platforms. The cross is on glass on iOS and a tonal circle on Android. The check is filled with your colour, or drawn muted and not as a button until there's a commit to send. Open issue is the same check, with a spinner while it opens. Android draws the sheet's handle over the content now, as iOS does, so the bar starts at the sheet's top edge there too. That's handle-over-content from NativePHP/mobile-ui#143, on the combined branch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
simonhamp
force-pushed
the
fix/sheet-buttons
branch
from
October 20, 2026 22:51
d62aefd to
5b66ee6
Compare
This was referenced Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compose sheet's bar had text buttons that didn't sit evenly in the sheet. On iOS, Cancel and Commit were about 28pt from the top but only 12pt from the sides. On Android they were plain text buttons under Material's handle strip.
Now Cancel is a cross and Commit a check, each in a 44pt circle, as Apple draws a sheet's bar. The bar's padding is 16pt all round, so both circles sit 16pt from the top and sides of the sheet on both platforms. Quote and Open issue use the same bar.
surface-variantcircle on Android.The circles are a new
sheet-bar-buttonpartial built onnative:pressable.native:buttondraws an icon-only button as a pill, not a circle, and its glass can't be made round.Android needed one NativePHP change, NativePHP/mobile-ui#143. Material's sheet keeps its drag handle in a 48dp strip above the content, so nothing can sit 16dp from the top. With
handle-over-content, Android draws an iOS-sized handle over the content instead. That's on the combined branch, andcomposer.lockhere picks it up. The report form and the receipts in the same sheet already start 24pt down, so they clear the handle on both platforms now.Things to check:
tests/Pest.php,sheetButtonEnabled()andsheetButtonCircle().🤖 Generated with Claude Code