Repository navigation
Bring native posting, notifications and profiles closer to web parity - #44
Merged
Merged
Conversation
Match one-character commits, URL-aware character budgets and URL parsing rules across native composers and replies, while keeping issue validation separate. Guard duplicate submissions and preserve retryable drafts. Link notification actors and GitHub bio mentions, compact the earned-badge shelf and large counts, and frame reply avatars in their lane colour. Refs: dev-null-sh/dev-null.sh#805, dev-null-sh/dev-null.sh#765, dev-null-sh/dev-null.sh#759, dev-null-sh/dev-null.sh#570, dev-null-sh/dev-null.sh#819, dev-null-sh/dev-null.sh#720, dev-null-sh/dev-null.sh#445. Validation: Pint passed. Non-architecture tests: 1,063 passed, 1 skipped, 2 deprecated. Architecture tests: 5 passed separately.
Keep upstream's flattened action buttons and border-based avatar rings, retaining compact counts, compact reply-ring geometry, and regression coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bring the native iOS/Android client closer to the website by porting a batch of independently verified changes from the web repository's history. This is a bounded parity batch, not a claim of complete web/mobile parity.
#42 is merged. This branch now includes the latest upstream
mainthrough8ce7482; Saved → Starred is already on the base branch and is no longer part of this PR's feature diff. The parity implementation isb88470e, with upstream conflict resolution in74c6075.Web commit → mobile implementation map
All source commits below are from
nunomaduro/dev-null.sh.1cc35cd— one char commitsc6497df— discount URLs in commit character allowance, #805c6497df, #805 and the web'sCodeSpans/commit.tsrules at that revision1cc35cd, which explicitly retains the issue minimum, andc6497df, whose URL discounts apply to commits/featureand/bugdrafts still require 3–4,000 literal characters. Their input caps, counters and submit eligibility do not inherit the one-character minimum or URL discounts. Private-message limits are unchanged.a281ca4— keep ellipses and curly quotes out of linked URLs, #765…,”and’from link destinations, alongside existing sentence punctuation. Preserve balanced URL brackets and keep punctuation as surrounding text.42f2f64— ignore submits while a commit is being posted, #759finally, so failed submissions retain their drafts and remain retryable.bf378fa— link the person in a notification to their profile, #515, followed by3e55ca6— preview and open profiles from notification actors, #570348537f— collapse profile achievement badges, #819+N morefor additional earned badges. ShowView achievementswhen none are earned. Keep every earned/locked badge, progress, rank and badge inspection available through the native achievements sheet.be434e6— tagged GitHub accounts in bios/company fields, #72050b08bb— shorten counts from a thousand, not only above it, #4451k,12.5k,1m. Handle rounding across unit boundaries. Keep full counts in existing star/pastel/follower accessibility labels.799dc10— ring reply avatars in their author's lane colorUpstream merge compatibility
The branch has been merged with upstream
mainafter #42 and the row-rendering improvements in #41 landed. Conflict resolution preserves both implementations:flex-rowaction pressables and existing touch-target dimensions, while retaining compact star/pastel text and full accessibility labels.Native adaptations and scope boundaries
Implementation guide
app/Devnull/Data/{Commit,CommitBody,BodyLink}.php;app/Devnull/IssueCommand.php.app/NativeComponents/Concerns/{OpensCommitSheet,DraftsIssues}.php,app/NativeComponents/CommitDetail.php, and the composer/reply/counter Blade views.app/NativeComponents/Notifications.php; notification, grouped-notification and stacked-avatar partials.app/Devnull/Data/Achievements.php; achievements shelf partial. The existing detailed sheet remains the inspection UI.app/Devnull/Data/Mention.php,app/NativeComponents/Profile.php, and the GitHub-text/profile partials.app/Devnull/Display.php; commit-action and profile-header partials.Validation
git diff --check: passed.Coverage added or adapted includes:
Device checks for reviewers