Repository navigation
Keep the thread on screen when you tap into the reply field - #31
Merged
Merged
Conversation
Tapping the reply field mounts the commit page's scroll view again under a new key, to bring the commit back to the top. Its rows hadn't changed, so EDGE's subtree reuse sent them as references to nodes the phone had dropped with the old scroll view, and the thread went blank as you started typing. The page now sends every frame in full, as the Log, Notifications, profiles and the other list screens already do. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The thread on a commit page went blank when you started typing a reply.
Tapping the reply field calls
replyTapped(), which bumps$scrollKeyso the thread's scroll view mounts again at the top with the commit you're answering. The rows inside it hadn't changed, so EDGE's subtree reuse sent them as references to nodes the phone had already dropped along with the old scroll view. The phone discards references it can't resolve, so the thread drew blank. It's the same failure the Log, Notifications, profiles, Saved, Remotes and conversations already avoid by sending every frame in full.This sets
$forceFullFramesonCommitDetailtoo, and adds it to the existing test for screens that send full frames.Worth checking
Every keystroke, debounced at 150 ms, now sends the whole commit page rather than just what changed. That's what the Log does on every render, and a commit page is smaller than a Log page, especially now the dashed lines are one view each.
Testing
1,003 tests pass and Pint is clean. I'm putting a build on the phone to confirm the thread stays put while typing.
🤖 Generated with Claude Code