Skip to content

Keep the thread on screen when you tap into the reply field - #31

Merged
simonhamp merged 1 commit into
mainfrom
fix/commit-page-full-frames
Oct 20, 2026
Merged

simonhamp merged 1 commit into
mainfrom
fix/commit-page-full-frames

Conversation

@simonhamp

Copy link
Copy Markdown
Member

The thread on a commit page went blank when you started typing a reply.

Tapping the reply field calls replyTapped(), which bumps $scrollKey so the thread's scroll view mounts again at the top with the commit you're answering. The rows inside it hadn't changed, so EDGE's subtree reuse sent them as references to nodes the phone had already dropped along with the old scroll view. The phone discards references it can't resolve, so the thread drew blank. It's the same failure the Log, Notifications, profiles, Saved, Remotes and conversations already avoid by sending every frame in full.

This sets $forceFullFrames on CommitDetail too, and adds it to the existing test for screens that send full frames.

Worth checking

Every keystroke, debounced at 150 ms, now sends the whole commit page rather than just what changed. That's what the Log does on every render, and a commit page is smaller than a Log page, especially now the dashed lines are one view each.

Testing

1,003 tests pass and Pint is clean. I'm putting a build on the phone to confirm the thread stays put while typing.

🤖 Generated with Claude Code

Tapping the reply field mounts the commit page's scroll view again under a
new key, to bring the commit back to the top. Its rows hadn't changed, so
EDGE's subtree reuse sent them as references to nodes the phone had
dropped with the old scroll view, and the thread went blank as you started
typing. The page now sends every frame in full, as the Log, Notifications,
profiles and the other list screens already do.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@simonhamp
simonhamp merged commit 1d58a28 into main Oct 20, 2026
1 check passed
@simonhamp
simonhamp deleted the fix/commit-page-full-frames branch October 20, 2026 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant