Skip to content

Welcome screen and dark theme - #2

Closed
kadirtikil wants to merge 5 commits into
NativePHP:mainfrom
kadirtikil:welcome-screen-and-dark-theme
Closed

kadirtikil wants to merge 5 commits into
NativePHP:mainfrom
kadirtikil:welcome-screen-and-dark-theme

Conversation

@kadirtikil

Copy link
Copy Markdown
Contributor

A new device opened on onboarding, a wall of text about SSH keys, and the app had no icon or splash screen. This brings the web's brand and welcome page across, and makes the app dark first like the web.

What changes

  • The mark. partials/mark.blade.php draws the web's AppLogoIcon, the ring with a slash, from EDGE shapes in theme colours, so it follows dark mode. The launch screen shows it instead of the word "devnull".
  • App icon and splash screens. public/icon.png, public/splash.png and public/splash-dark.png, rendered from the same mark. The splash draws it at 288px, the launch screen's 96pt at 3x, so nothing jumps when the app takes over.
  • A welcome screen (/welcome). The web's welcome page, as three commits on the rail: the wordmark, the pitch, and a hollow node for the commit you haven't made yet, the Sign in with GitHub button. It doesn't touch the Keychain, so the key is only made once someone chooses to sign in.
  • New devices open on it. Launch sends an unverified device to /welcome instead of /onboarding. Verified devices still go straight to the log.
  • One tap to sign in. Sign in with GitHub opens onboarding with the device flow already started, so the code to enter on GitHub is the first thing you see. Without a GitHub app configured (DEVNULL_GITHUB_CLIENT_ID), onboarding offers adding the key by hand, as before.
  • Dark on iOS. UIUserInterfaceStyle = Dark goes in nativephp.permissions, which NativePHP merges into Info.plist after every plugin. The app, its splash and its system chrome are dark whatever the phone is set to. Every element already carried its dark colours, so no views changed.

Open questions

  • Dark only? The web follows the system theme by default, with a switch. This pins iOS to dark. If you'd rather follow the system, it's a one-line revert of the last commit.
  • Android isn't pinned. NativePHP has no app-level setting for night mode there, so it would need a small plugin.
  • No GitHub logo on the button: neither SF Symbols nor Material Icons has one.
  • The sign-in node is green, not blue. The web uses the primary colour for it, but the rail only draws author lanes.

Testing

  • 247 tests pass, on every commit. New tests cover the welcome screen (it never calls the Keychain, it passes the accessibility audit, it leads to onboarding) and onboarding starting the device flow on arrival, with and without a GitHub app.
  • Checked the icon and splash images and the mark's rendered tree. I haven't run this branch on a device yet, so screenshots will follow.

Screenshots

image

The launch screen said "devnull" in plain text. It now shows the web's mark,
the ring with a slash through it, drawn from EDGE shapes in theme colours so
it follows dark mode.
The web's welcome page, as three commits on the rail: the wordmark, the
pitch, and a hollow node for the commit you haven't made yet, the sign-in
button. Signing in goes on to onboarding. Nothing here touches the Keychain,
so the key is only made once someone chooses to sign in.
A device that isn't verified went straight to onboarding, a wall of text
about SSH keys. It now lands on the welcome screen, and onboarding is one
tap away.
Sign in with GitHub opened onboarding, where you had to tap Connect with
GitHub again. It now asks onboarding to start the device flow on arrival,
so the code to enter on GitHub is the first thing you see. Without a GitHub
app configured, onboarding offers adding the key by hand as before.
devnull is dark first, like the web. UIUserInterfaceStyle pins the app,
its splash and its system chrome (status bar, keyboard, sheets) to dark,
and every element already carries its dark colours. The key goes in
nativephp.permissions, which NativePHP merges into Info.plist after every
plugin.
@kadirtikil
kadirtikil force-pushed the welcome-screen-and-dark-theme branch from 92eb170 to fd329a8 Compare October 16, 2026 14:29

@RaphaelFakhri RaphaelFakhri left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kadirtikil main has moved past the sign-in this PR builds on: e796c89 replaced the GitHub device flow with sign-in through dev-null.sh, so Onboarding::connectGitHub() and GitHubStep no longer exist, and OnboardingGitHubTest.php is deleted on main. The branch conflicts in Launch.php, config/nativephp.php and that test, and the Onboarding.php hunk merges without a conflict but lands in the wrong method. On a local merge of this branch into main (taking main's side of the conflicts and pointing Launch at /welcome), the hunk ends up inside signIn(), so tapping the onboarding button after arriving from /welcome throws Call to undefined method App\NativeComponents\Onboarding::connectGitHub(). The app icon and splash are already on main (96d212c, 4ed97a1), so the parts still worth keeping are the mark on the launch screen (main still shows the "devnull" text there), the welcome screen, and the dark-only decision. Consider rebasing those onto main, with Welcome going to onboarding's dev-null.sh sign-in and no github flag, plus before and after screenshots on iOS and Android in light and dark mode as CONTRIBUTING.md now asks.

}

// Sign in with GitHub on the welcome screen means the device flow, so skip the tap that starts it.
if ($this->data('github') === true) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

connectGitHub() is gone on main since the move to dev-null.sh sign-in. After a merge this block lands inside signIn() and throws on the first tap.

Comment thread config/nativephp.php
*/

'permissions' => [
// Not a permission, but this is where app-level Info.plist keys go. devnull is dark first, like the web, so

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main's permissions now holds the camera and photo library strings, so this conflicts. If you keep dark-only, add the key alongside them.

@simonhamp

Copy link
Copy Markdown
Member

closing this as most items have been resolved. I don't think defaulting to dark mode is right

we'll revisit welcome screen closer to public release

@simonhamp simonhamp closed this Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants