Repository navigation
Welcome screen and dark theme - #2
kadirtikil wants to merge 5 commits into
Conversation
The launch screen said "devnull" in plain text. It now shows the web's mark, the ring with a slash through it, drawn from EDGE shapes in theme colours so it follows dark mode.
The web's welcome page, as three commits on the rail: the wordmark, the pitch, and a hollow node for the commit you haven't made yet, the sign-in button. Signing in goes on to onboarding. Nothing here touches the Keychain, so the key is only made once someone chooses to sign in.
A device that isn't verified went straight to onboarding, a wall of text about SSH keys. It now lands on the welcome screen, and onboarding is one tap away.
Sign in with GitHub opened onboarding, where you had to tap Connect with GitHub again. It now asks onboarding to start the device flow on arrival, so the code to enter on GitHub is the first thing you see. Without a GitHub app configured, onboarding offers adding the key by hand as before.
devnull is dark first, like the web. UIUserInterfaceStyle pins the app, its splash and its system chrome (status bar, keyboard, sheets) to dark, and every element already carries its dark colours. The key goes in nativephp.permissions, which NativePHP merges into Info.plist after every plugin.
92eb170 to
fd329a8
Compare
RaphaelFakhri
left a comment
There was a problem hiding this comment.
@kadirtikil main has moved past the sign-in this PR builds on: e796c89 replaced the GitHub device flow with sign-in through dev-null.sh, so Onboarding::connectGitHub() and GitHubStep no longer exist, and OnboardingGitHubTest.php is deleted on main. The branch conflicts in Launch.php, config/nativephp.php and that test, and the Onboarding.php hunk merges without a conflict but lands in the wrong method. On a local merge of this branch into main (taking main's side of the conflicts and pointing Launch at /welcome), the hunk ends up inside signIn(), so tapping the onboarding button after arriving from /welcome throws Call to undefined method App\NativeComponents\Onboarding::connectGitHub(). The app icon and splash are already on main (96d212c, 4ed97a1), so the parts still worth keeping are the mark on the launch screen (main still shows the "devnull" text there), the welcome screen, and the dark-only decision. Consider rebasing those onto main, with Welcome going to onboarding's dev-null.sh sign-in and no github flag, plus before and after screenshots on iOS and Android in light and dark mode as CONTRIBUTING.md now asks.
| } | ||
|
|
||
| // Sign in with GitHub on the welcome screen means the device flow, so skip the tap that starts it. | ||
| if ($this->data('github') === true) { |
There was a problem hiding this comment.
connectGitHub() is gone on main since the move to dev-null.sh sign-in. After a merge this block lands inside signIn() and throws on the first tap.
| */ | ||
|
|
||
| 'permissions' => [ | ||
| // Not a permission, but this is where app-level Info.plist keys go. devnull is dark first, like the web, so |
There was a problem hiding this comment.
Main's permissions now holds the camera and photo library strings, so this conflicts. If you keep dark-only, add the key alongside them.
|
closing this as most items have been resolved. I don't think defaulting to dark mode is right we'll revisit welcome screen closer to public release |
A new device opened on onboarding, a wall of text about SSH keys, and the app had no icon or splash screen. This brings the web's brand and welcome page across, and makes the app dark first like the web.
What changes
partials/mark.blade.phpdraws the web'sAppLogoIcon, the ring with a slash, from EDGE shapes in theme colours, so it follows dark mode. The launch screen shows it instead of the word "devnull".public/icon.png,public/splash.pngandpublic/splash-dark.png, rendered from the same mark. The splash draws it at 288px, the launch screen's 96pt at 3x, so nothing jumps when the app takes over./welcome). The web's welcome page, as three commits on the rail: the wordmark, the pitch, and a hollow node for the commit you haven't made yet, the Sign in with GitHub button. It doesn't touch the Keychain, so the key is only made once someone chooses to sign in.Launchsends an unverified device to/welcomeinstead of/onboarding. Verified devices still go straight to the log.DEVNULL_GITHUB_CLIENT_ID), onboarding offers adding the key by hand, as before.UIUserInterfaceStyle = Darkgoes innativephp.permissions, which NativePHP merges into Info.plist after every plugin. The app, its splash and its system chrome are dark whatever the phone is set to. Every element already carried its dark colours, so no views changed.Open questions
Testing
Screenshots