[dashboards] Fix source filter firing navigation on every keystroke

[swhitt]

Contribution Type

• Dashboard (/dashboards)

What does this do?

The Source text input in ThoughtsFilter calls router.push() on every onChange event, triggering a full server-side navigation for each character typed. Typing "chatgpt_import" fires 16 navigations in rapid succession.

Fix: use local state for the input value, apply the filter on blur or Enter. The select-based filters (Type, Importance) are unaffected since they commit on selection, not per-keystroke.

Requirements

Nothing new.

Checklist

• I've read CONTRIBUTING.md
• My contribution has a README.md with prerequisites, step-by-step instructions, and expected outcome (n/a - see PR body)
• My metadata.json has all required fields (n/a)
• I tested this on my own Open Brain instance
• No credentials, API keys, or secrets are included

README and metadata.json not applicable for a single-file bug fix.

[shansen3]

Code review

Found 1 issue:

1. State desync when URL changes externally. sourceInput is initialized once via useState(currentSource) but never syncs back when currentSource changes (e.g., browser back/forward, another filter clearing the URL param). The text input will show a stale value that doesn't match the active filter. Add a useEffect to sync: useEffect(() => { setSourceInput(currentSource ?? ""); }, [currentSource]);

OB1/dashboards/open-brain-dashboard-next/components/ThoughtsFilter.tsx

Lines 19 to 21 in b36cfc2

	const router = useRouter();
	const [sourceInput, setSourceInput] = useState(currentSource);

🤖 Generated with Claude Code

_{- If this code review was useful, please react with 👍. Otherwise, react with 👎.}

[swhitt]

Good catch, thanks. Fixed in 253560e. Added a useEffect to sync sourceInput when currentSource changes externally (back/forward, URL edits).

[matthallett1]

@claude review this PR

[matthallett1]

@claude review this PR

[github-actions]

Claude finished @matthallett1's task in 46s —— View job

---

Code Review

• Read changed file
• Review implementation
• Post findings

---

The fix is correct and well-scoped. Here's my assessment:

What changed (ThoughtsFilter.tsx):

• sourceInput local state buffers keystrokes instead of hitting the router on every onChange
• Filter applies on blur (with a guard: only if value differs from currentSource) or on Enter
• A useEffect syncs sourceInput back to currentSource when the URL changes externally (back/forward nav, other filters clearing the param) — this addresses the issue that was caught and fixed in 253560e

The implementation is sound. A few minor observations:

1. onKeyDown Enter doesn't guard against no-op — unlike onBlur, pressing Enter when sourceInput === currentSource still calls applyFilters. This is harmless (it pushes the same URL) but slightly inconsistent with the blur guard.

   • Fix this →

2. useEffect is one-liner — inline form on line 22 is compact but slightly harder to scan. Not a blocker.

3. currentSource prop typed as string but used with ?? "" in applyFilters — prop type should be string | undefined to match actual usage, or the nullish coalescing should be removed. Minor inconsistency.

   • Fix this →

Checklist:

• Alignment: yes — dashboard bug fix, directly improves existing UX
• Safety: no credentials, no SQL, no schema changes
• Scope: appropriately minimal — single-file fix
• Prior review addressed: yes — the useEffect sync is in place

Verdict: LGTM. The two minor items above are worth noting but neither blocks merging. The core fix is correct, the state desync from the previous review has been addressed, and the UX is meaningfully improved.

---

[matthallett1]

Clean bugfix — local state + blur/Enter commit is the standard React pattern. State desync addressed in 253560e. Reviewed with gstack /review and automated review, no issues.