Bnb/feat specific proxy obs#319
Open
bnb32 wants to merge 9 commits into
Open
Conversation
… obs fractions and perturbation scales
… better traceability
…loss metric readability
…el for improved training dynamics
…trategy. change to_dataarray() to return empty array when dset has no features. This enables runnning fwp without any lr features
…ss and ForwardPassStrategy
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds feature-specific proxy observation configuration and related observation-training utilities, while also adjusting empty-feature data handling and logging.
Changes:
- Adds per-feature proxy observation overrides for observation fractions and perturbation scale.
- Introduces
ObsAssimilationLossandobs_mask_fractiontraining support for observation-based workflows. - Fixes empty-feature forward-pass/data access behavior and updates tests/log messages.
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
sup3r/preprocessing/samplers/base.py |
Implements per-feature proxy obs masks and perturbation handling. |
sup3r/preprocessing/samplers/dual.py |
Centralizes duplicated sampler documentation. |
sup3r/preprocessing/samplers/dc.py |
Centralizes duplicated sampler documentation. |
sup3r/preprocessing/samplers/cc.py |
Centralizes docs and reformats coarsening call. |
sup3r/preprocessing/batch_queues/dc.py |
Centralizes duplicated batch queue documentation. |
sup3r/preprocessing/accessor.py |
Returns zero-channel arrays for empty feature selections. |
sup3r/preprocessing/derivers/base.py |
Demotes derive-completion logging to debug. |
sup3r/models/base.py |
Adds obs_mask_fraction model parameter persistence. |
sup3r/models/abstract.py |
Adds obs masking in generator training and TF/distribution updates. |
sup3r/utilities/loss_metrics.py |
Adds ObsAssimilationLoss. |
sup3r/pipeline/strategy.py |
Updates input/exo logging. |
sup3r/pipeline/forward_pass.py |
Updates chunk logging wording. |
sup3r/pipeline/forward_pass_cli.py |
Adds head-node strategy initialization log. |
tests/samplers/test_with_obs.py |
Tests per-feature proxy obs override behavior. |
tests/utilities/test_loss_metrics.py |
Tests new obs assimilation loss behavior. |
tests/forward_pass/test_forward_pass.py |
Tests all-low-res-features-as-exo edge case. |
tests/data_wrapper/test_access.py |
Updates expectations for lat/lon access behavior. |
pyproject.toml |
Bumps TensorFlow patch version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds feature specific overrides for proxy observation parameters like perturbation scale, obs fractions, etc.