Skip to content

Update workflow to build pysam - #221

Merged
sjanzou merged 139 commits into
mainfrom
191-full-pysam-build-in-github-ci
Jul 21, 2026
Merged

Update workflow to build pysam#221
sjanzou merged 139 commits into
mainfrom
191-full-pysam-build-in-github-ci

Conversation

@sjanzou

@sjanzou sjanzou commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Note

  1. the workflow is for the Windows runner only - separate pull requests for Linux and MacOS coming
  2. the tests for the cec module and inverter only pass with python 3.11 and higher

sjanzou added 30 commits June 11, 2026 02:41
@sjanzou
Testing conda environment on Windows workflow
fbf6645
@sjanzou
trigger ci.yml on push
b7be77e
@sjanzou
Update to test conda-incubator in ci.yml
90a9041
@sjanzou
update conda environment switching in ci.yml
ba3a9d3
@sjanzou
update ci.yml to install and list all conda environments
dae059a
@sjanzou
ci.yml - add additional dependencies
7e50244
@sjanzou
ci.yml syntax errors
bcaf869
@sjanzou
ci.yml syntax
8f981ab
@sjanzou
ci.yml syntax
97be643
@sjanzou
ci.yml debugging
ab6eb85
@sjanzou
move all settings in each conda environment
b24cf69
@sjanzou
ci.yml updates for SAM api
74abdb4
@sjanzou
ci.yml pathing issue
daa4d12
@sjanzou
add msbuild to build sam_api in ci.yml workflow
7cfe9fb
@sjanzou
update step order and building specific project in ci.yml
c31ea61
@sjanzou
update relative paths and msbuild command
8061f32
@sjanzou
added environment variable
737a3d0
@sjanzou
add missing build folder and configure in sam folder
8844113
@sjanzou
leave generator switch out as suggested by GitHub
422e1a2
@sjanzou
msbuild still failing - update command line
4ac99bd
@sjanzou
update to use modified api_autogen CMakeLists in sam
4cdff5e
@sjanzou
comment to test api_autogen CMakeLists.txt from SAM api_autogen
b5e4044
@sjanzou
Clone specific branch of SAM
7d4ce8c
@sjanzou
branch environment variable not working
d38eff1
@sjanzou
resolving issues with api_autogen project in SAM
eb5525b
@sjanzou
configuring failing without wxWidgets, lk, wex
38f014b
@sjanzou
ci.yml updated based on local Windows 11 build
29c2bd8
@sjanzou
ci.yml - update default branch to develop to resolve other repos
ab80d66
@sjanzou
Update workflow to build through api_autogen for testing
03268ef
@sjanzou
Update SSDIR environment variable
0d9b156
@sjanzou sjanzou self-assigned this Jul 17, 2026
@sjanzou
sjanzou requested a review from brtietz July 17, 2026 09:06
@sjanzou sjanzou linked an issue Jul 17, 2026 that may be closed by this pull request
Full PySAM Build in Github CI #191
Closed
@sjanzou
sjanzou requested a review from cpaulgilman July 17, 2026 09:06
brtietz
brtietz reviewed Jul 17, 2026
View reviewed changes

@brtietz brtietz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! A few minor questions/comments on branch names, but this should be good to go soon.

Comment thread .github/workflows/ci.yml Outdated

env:
BUILD_TYPE: Release
DEFAULT_BRANCH: develop

@brtietz brtietz Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing this to patch now will save a pull request later. (I think technically it should be main, but we haven't been in the habit of making main line up since it typically only builds once)

@sjanzou sjanzou Jul 19, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brtietz, note that the default branch is used as a fallback for lk, wex, ssc, and SAM in the "Determine branches for other repos" step. Another argument for aligning pysam with out other branch structures. Changed to "patch" in latest commit.

Comment thread .github/workflows/test_pkg.yml Outdated
#on: [ push ]
on:
push:
branches: [ main, dev ]

@brtietz brtietz Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be updated to our new branch structure? (main, develop, patch)

@sjanzou sjanzou Jul 19, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brtietz, test_pkg.yml was the old workflow that only tested the latest PyPi release and has been removed in the latest commit.

sjanzou added 17 commits July 19, 2026 02:22
@sjanzou
Address comments in #221
7d48a59
@sjanzou
Update ci.yml to ci-windows.yml and add Linux workflow
0e795b1
@sjanzou
update syntax issue for Linux workflow and have windows trigger on ma…
aa62475 
…in only
@sjanzou
Build libssc.so instead of ssc.so and comment out failing steps for c…
cf8e8f6 
…aching builds
@sjanzou
Test api_autogen building on Linux
1081e22
@sjanzou
fix syntax error in api_autogen step
dded843
@sjanzou
Update api_autogen linux build step
245f6e8
@sjanzou
Linux SAM_api building - re-enable all steps
c5c5b73
@sjanzou
update prepare_build.py for libSAM_api.so for Linux search path
e16e735
@sjanzou
Update libSAM_api.so search path for Linux
48f1e62
@sjanzou
pysam building but tests failing - run specific test
c5c6243
@sjanzou
test skipping test_BatteryTools.py on Linux
00ca2ca
@sjanzou
add ci-macos for x86_64 and test building and cache lk, wex, ssc
c61f7bc
@sjanzou
comment out failing steps on macos to cache wxWidets build
891fb06
@sjanzou
update wxWidgets flags to c++17 and enable macos cache and build of l…
b21bd9d 
…k, wex, and ssc
@sjanzou
Enable all steps for ci-macos workflow and update search paths
7bba23a
@sjanzou
ci-windows, ci-linux, and ci-macos enabled for all branches
e40ad6f 
test_BatteryTools.py still skipped for Linux and macOS until Linux issue resolved.
@sjanzou
sjanzou requested a review from brtietz July 20, 2026 10:02
@sjanzou
sjanzou merged commit 8d63b07 into main Jul 21, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brtietz brtietz brtietz approved these changes
@cpaulgilman cpaulgilman Awaiting requested review from cpaulgilman

Assignees

@sjanzou sjanzou

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Full PySAM Build in Github CI

2 participants

@sjanzou @brtietz