Fixes Issue #170#171
Merged
Merged
Conversation
I confirmed fix on the test model. I also confirmed that if I try to use space name as zone name in OS app that it renames it, so adding prefix seems like good approach. I hard coded "zone " but could make an argument if there is interest or an option to look for and swap out "space" if it is found with "zone"
There was a problem hiding this comment.
Pull request overview
Updates the merge_floorspace_js_with_model OpenStudio measure to avoid OpenStudio Application renaming behavior when a newly created ThermalZone name matches a Space name (Issue #170) by adding a zone-name prefix.
Changes:
- Prefix newly created ThermalZone names with
"zone "when assigning zones to previously-unzoned spaces. - Bump the measure metadata version (version_id / version_modified) and update the
measure.rbchecksum inmeasure.xml.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/measures/merge_floorspace_js_with_model/measure.rb | Prefixes auto-created ThermalZone names to prevent collisions with Space names. |
| lib/measures/merge_floorspace_js_with_model/measure.xml | Updates measure version metadata and checksum to reflect the script change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
github-project-automation
Bot
moved this from Ready to Test
to Done
in OpenStudio Measure Gems
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I confirmed fix on the test model. I also confirmed that if I try to use space name as zone name in OS app that it renames it, so adding prefix seems like good approach. I hard coded "zone " but could make an argument if there is interest or an option to look for and swap out "space" if it is found with "zone"