Use public SolarPosition API for UWISC solar-angle derivation#90
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix code based on review comment 3325684192
Use public Jun 4, 2026
SolarPosition API for UWISC solar-angle derivation
bnb32
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the review concern that preprocessing relied on private
rexinternals (SolarPosition._zenith/_azimuth), which are unstable across upstream upgrades. The implementation now uses the publicSolarPositioninterface while preserving existing 2D output behavior.Solar angle derivation now uses public API
BaseUwiscDataModelwith:SolarPosition(time_index, lat_lon_pairs).zenithSolarPosition(time_index, lat_lon_pairs).azimuth(N, 2)pairs forSolarPosition, then reshaped back to the original spatial grid.Focused regression coverage
SolarPositionand verifies:(lat, lon)pair ordering passed into the constructor,zenithandazimuthoutputs are reshaped back to(south_north, west_east).