feat: replace UUID-based identifiers with stable integer IDs by pesap · Pull Request #156 · NatLabRockies/infrasys

pesap · 2026-05-24T01:46:46Z

Components, supplemental attributes, and time series metadata now use monotonically-increasing integer IDs as their primary identifier. Legacy UUIDs are preserved as legacy_uuid for backward compatibility.

Key changes:

InfraSysBaseModelWithIdentifiers: new id field (int), legacy_uuid for BC
IDManager: tracks next available ID, supports advance_past() for serialized data with pre-assigned IDs
SQLite tables use INTEGER foreign keys with referential integrity
ComponentAssociations, SupplementalAttributeAssociations, and TimeSeriesMetadataStore all migrated to integer ID columns
Migration logic for legacy serialized data and existing SQLite schemas
New get_by_id() methods on ComponentManager, SupplementalAttributeManager
SerializedComponentReference uses integer id instead of UUID
Fixed double-negative bug in metadata_store_needs_migration
copy.deepcopy replaces manual model_dump() reconstruction
Backward-compat alias InfraSysBaseModelWithIdentifers preserved

Components, supplemental attributes, and time series metadata now use monotonically-increasing integer IDs as their primary identifier. Legacy UUIDs are preserved as `legacy_uuid` for backward compatibility. Key changes: - InfraSysBaseModelWithIdentifiers: new id field (int), legacy_uuid for BC - IDManager: tracks next available ID, supports advance_past() for serialized data with pre-assigned IDs - SQLite tables use INTEGER foreign keys with referential integrity - ComponentAssociations, SupplementalAttributeAssociations, and TimeSeriesMetadataStore all migrated to integer ID columns - Migration logic for legacy serialized data and existing SQLite schemas - New get_by_id() methods on ComponentManager, SupplementalAttributeManager - SerializedComponentReference uses integer id instead of UUID - Fixed double-negative bug in metadata_store_needs_migration - copy.deepcopy replaces manual model_dump() reconstruction - Backward-compat alias InfraSysBaseModelWithIdentifers preserved

codecov-commenter · 2026-05-24T01:47:49Z

Codecov Report

❌ Patch coverage is 94.23299% with 50 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.78%. Comparing base (1971984) to head (7fb5d05).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...rc/infrasys/supplemental_attribute_associations.py	69.30%	31 Missing ⚠️
src/infrasys/time_series_metadata_store.py	93.23%	9 Missing ⚠️
src/infrasys/component_manager.py	92.59%	6 Missing ⚠️
src/infrasys/component_associations.py	92.30%	2 Missing ⚠️
src/infrasys/supplemental_attribute_manager.py	93.33%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #156      +/-   ##
==========================================
- Coverage   94.82%   94.78%   -0.05%     
==========================================
  Files          61       62       +1     
  Lines        6072     6802     +730     
==========================================
+ Hits         5758     6447     +689     
- Misses        314      355      +41

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

Pull request overview

This PR migrates InfraSys object identifiers from UUIDs to stable, monotonically-increasing integer IDs across components, supplemental attributes, and time series metadata while retaining legacy UUIDs for backward compatibility.

Changes:

Introduces integer id fields (with legacy_uuid retained for BC) and updates serialization/deserialization to use integer IDs for references.
Migrates SQLite schemas and association tables (components, supplemental attributes, time series metadata) to integer foreign keys and adds migration helpers for legacy UUID-based data.
Updates public accessors/managers and test suite expectations to use get_by_id() / owner_id / time_series_id paths.

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
tests/test_system.py	Updates record and SQL assertions to validate integer IDs and storage-key UUIDs.
tests/test_supplemental_attributes.py	Makes assertions resilient to ordering by comparing coordinate sets.
tests/test_serialization.py	Switches component lookups to `get_component_by_id()` and adds explicit ID-serialization coverage.
src/infrasys/utils/metadata_utils.py	Updates SQLite table schemas/indexes to integer FK columns and enables foreign keys.
src/infrasys/time_series_models.py	Adds `time_series_id` into metadata models and sets it during `from_data()`.
src/infrasys/time_series_metadata_store.py	Migrates association columns to integer IDs + storage keys and adds legacy table migration/remapping logic.
src/infrasys/time_series_manager.py	Assigns integer IDs to time series and exposes metadata schema migration hook.
src/infrasys/system.py	Adds legacy upgrade path for serialized references, new `get_*_by_id()` APIs, and triggers metadata/schema migrations on load.
src/infrasys/supplemental_attribute_manager.py	Adds ID-based attribute indexing/lookup and association schema migration call.
src/infrasys/supplemental_attribute_associations.py	Converts association storage and queries from UUID columns to integer ID columns.
src/infrasys/serialization.py	Updates `SerializedComponentReference` to store integer IDs with legacy UUID as excluded BC field.
src/infrasys/models.py	Replaces UUID base identifier with integer `id` + `legacy_uuid`, and extends label parsing to handle ints.
src/infrasys/migrations/db_migrations.py	Fixes migration predicate and routes legacy inserts through the updated metadata store insert path.
src/infrasys/id_manager.py	Adds `advance_past()` to support externally-supplied IDs during deserialization/migration.
src/infrasys/component.py	Serializes composed component references using integer IDs and errors if ID is missing.
src/infrasys/component_manager.py	Adds ID indexing/lookup, updates composed-component association logic to use IDs, and switches deepcopy to `copy.deepcopy`.
src/infrasys/component_associations.py	Converts component association storage/querying from UUIDs to integer IDs with parent-ID insertion.
src/infrasys/init.py	Removes duplicate constant definition.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- Fix ComponentManager.remove() index cleanup only triggering on empty container (P1 bug) - Fix get_by_label() to try name-based lookup before ID for numeric labels (P1 ambiguity) - Add owner_category to time series unique index to prevent false collisions across owner types - Extract migration functions to src/infrasys/utils/migrations.py - Raise NotImplementedError for deprecated get_component_uuids_with_attribute - Merge duplicate query strings in supplemental attribute associations - Add Field descriptions to SerializedComponentReference - Add cascade warning when removing components with time series - Add migration path tests and remove-index cleanup test

…nent associations Covers: - SerializedComponentReference.uuid property (success + error) - get_class_and_name_from_label with UUID and unknown string labels - ComponentAssociations.clear operation - list_child_components/list_parent_components with type filter - get_by_label with UUID-based labels

pesap · 2026-05-24T02:14:32Z

@daniel-thom, is this what you had in mind?

Copilot

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 6 comments.

Copilot

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated 5 comments.

- fix duplicate list_time_series_metadata call in remove_component - widen sql() params type from Sequence[str] to Sequence[Any] - guard MAX(*_id) queries with column existence checks for legacy DBs - add 17 tests covering component associations, ID management, migrations, supplemental attribute queries, and time series metadata normalization

Copilot

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated 4 comments.

    class_name, name = label.split(".", maxsplit=1)
-    name_or_uuid: str | UUID = name
+    name_or_uuid: str | int | UUID = name
+    try:
+        name_or_uuid = int(name)
+        return class_name, name_or_uuid
+    except ValueError:


-        query = f"SELECT 1 FROM {TIME_SERIES_ASSOCIATIONS_TABLE} WHERE time_series_uuid = ?"
+        query = f"SELECT 1 FROM {TIME_SERIES_ASSOCIATIONS_TABLE} WHERE time_series_storage_key = ?"
        row = execute(cur, query, params=(str(time_series_uuid),)).fetchone()
        return row


… type, replace asserts with domain exceptions Agent-Logs-Url: https://github.com/NatLabRockies/infrasys/sessions/070e4fb1-22bd-4d30-8a82-321e1f62f210 Co-authored-by: pesap <2238996+pesap@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated 3 comments.

    def raise_if_attached(self, component: Component):
        """Raise an exception if this component is attached to a system."""
-        if component.uuid in self._components_by_uuid:
+        if component.id is not None and component.id in self._components_by_id:
            msg = f"{component.label} is already attached to the system"
            raise ISAlreadyAttached(msg)


+        if component.id is None:
+            component.id = self._id_manager.get_next_id()
+        elif component.id in self._components_by_id:
+            msg = f"{component.label} with id={component.id} is already stored"
+            raise ISAlreadyAttached(msg)
+        else:
+            self._id_manager.advance_past(component.id)


        if not owners:
            msg = "At least one component must be passed."
            raise ISOperationNotAllowed(msg)


pesap requested review from Copilot and daniel-thom May 24, 2026 01:46

github-actions Bot added the tests label May 24, 2026

Copilot started reviewing on behalf of pesap May 24, 2026 01:47 View session

Copilot AI reviewed May 24, 2026

View reviewed changes

Comment thread src/infrasys/supplemental_attribute_manager.py Outdated

Comment thread src/infrasys/component_manager.py Outdated

Comment thread src/infrasys/time_series_metadata_store.py Outdated

Comment thread src/infrasys/utils/metadata_utils.py

Comment thread src/infrasys/models.py Outdated

pesap commented May 24, 2026

View reviewed changes

pesap added 2 commits May 23, 2026 20:04

pesap requested a review from Copilot May 24, 2026 02:10

Copilot started reviewing on behalf of pesap May 24, 2026 02:11 View session

Copilot AI reviewed May 24, 2026

View reviewed changes

fix: address Copilot review findings on integer ID migration

39769fd

pesap requested a review from Copilot May 24, 2026 04:18

Copilot started reviewing on behalf of pesap May 24, 2026 04:18 View session

Copilot AI reviewed May 24, 2026

View reviewed changes

Comment thread src/infrasys/models.py Outdated

Comment thread src/infrasys/time_series_metadata_store.py Outdated

Comment thread src/infrasys/time_series_manager.py Outdated

Comment thread src/infrasys/time_series_metadata_store.py Outdated

Comment thread src/infrasys/system.py Outdated

pesap requested a review from Copilot May 24, 2026 04:59

Copilot started reviewing on behalf of pesap May 24, 2026 04:59 View session

Copilot AI reviewed May 24, 2026

View reviewed changes

Copilot started work on behalf of pesap May 24, 2026 16:33 View session

Copilot finished work on behalf of pesap May 24, 2026 16:39

pesap force-pushed the feat/ids branch from e185374 to bb57427 Compare June 10, 2026 19:52

fix: improving handling of removal.

54bf217

pesap requested a review from Copilot June 10, 2026 21:17

Copilot started reviewing on behalf of pesap June 10, 2026 21:17 View session

Copilot AI reviewed Jun 10, 2026

View reviewed changes

Comment thread src/infrasys/component_manager.py Outdated

Comment thread src/infrasys/system.py Outdated

pesap added 2 commits June 10, 2026 17:21

fix(ids): reject foreign component collisions

90d5e28

fix(ids): validate component association traversal

7fb5d05

pesap requested a review from Copilot June 10, 2026 23:36

Copilot started reviewing on behalf of pesap June 10, 2026 23:36 View session

Copilot AI reviewed Jun 10, 2026

View reviewed changes

Conversation

pesap commented May 24, 2026

Uh oh!

codecov-commenter commented May 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pesap commented May 24, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov-commenter commented May 24, 2026 •

edited

Loading