Check allowing pandas v3#1194
Conversation
|
Works for me! |
|
Within the core code, I think pandas is only used in two places:
It's also used rather minimally in two examples and one test (after I've now removed some unused imports). I'm comfortable allowing pandas 3 (but will continue to allow pandas 2, as I suspect many users will not have upgraded) |
|
FWIW we could eliminate the second usage with numpy.loadtxt. The first one might be more involved, but generally it feels like an anti pattern if that's the only place where we're using a dataframe. @misi9170 what do you think about eliminating Pandas as a dependency all together? I can take a stab at this if you agree. |
|
@rafmudaf , I'd be very on board, but my one hesitation is that the |
|
@misi9170 I made the change in the turbine file. As for the velocity deficit profile function, I'm happy to add a warning, but I also lean toward your latter perspective. I think it's a lightly enough used function and we could make the change clear in the release notes. |
|
And just for documentation, I used np.genfromtxt because it creates a named array from the header row directly whereas |
|
I agree on all fronts, thanks @rafmudaf . Looks like all checks are passing, so I'll merge unless you are planning on any more changes |
|
Good to go from my end. Thanks @misi9170 |
As raised in #1193 , pandas v3 was released earlier this year and it would be nice to have FLORIS be compatible.
I have so far simply updated the dependencies and run tests, but not examples; opening this PR should run the examples. Assume they all execute correctly without error, it's likely we can simply support both pandas v2 and pandas v3, which would be my preference over dropping pandas v2 support.