Skip to content

feat: enable can-imports translation if parser allows it - #323

Merged
mcllerena merged 3 commits into
mainfrom
ml/add-imports
Aug 25, 2026
Merged

feat: enable can-imports translation if parser allows it#323
mcllerena merged 3 commits into
mainfrom
ml/add-imports

Conversation

@mcllerena

@mcllerena mcllerena commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Enable PLEXOS translation for "imports" category from ReEDS.

@codecov-commenter

codecov-commenter commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.43%. Comparing base (bad738d) to head (2a4539f).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #323      +/-   ##
==========================================
+ Coverage   85.33%   85.43%   +0.09%     
==========================================
  Files          20       20              
  Lines        5584     5594      +10     
==========================================
+ Hits         4765     4779      +14     
+ Misses        819      815       -4     
Files with missing lines Coverage Δ
...to-plexos/src/r2x_reeds_to_plexos/getters_utils.py 92.60% <100.00%> (+0.29%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mcllerena
mcllerena marked this pull request as ready for review August 24, 2026 14:16
Copilot AI lite review requested due to automatic review settings August 24, 2026 14:16
@mcllerena
mcllerena requested a review from akrivi August 24, 2026 14:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables translation of imports generators into PLEXOS and transfers their time series.

Changes:

  • Includes imports in generator rule filtering.
  • Adds import-generator time-series handling.
  • Adds integration coverage.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Summary
packages/r2x-reeds-to-plexos/tests/test_translation_rule_application.py Adds import-generator translation coverage.
packages/r2x-reeds-to-plexos/src/r2x_reeds_to_plexos/getters_utils.py Adds time-series transfer, but a critical issue drops feature metadata and can misattach or collapse profiles.
packages/r2x-reeds-to-plexos/src/r2x_reeds_to_plexos/config/rules.json Enables the imports generator category.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread packages/r2x-reeds-to-plexos/src/r2x_reeds_to_plexos/getters_utils.py Outdated

@akrivi akrivi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, Marck!

@mcllerena
mcllerena merged commit a5801e0 into main Aug 25, 2026
17 checks passed
@mcllerena
mcllerena deleted the ml/add-imports branch August 25, 2026 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants