Fix #5625 - Update BCL to point to the new address - #5639
Merged
Conversation
jmarrec
added
severity - Blocker
component - Measure Manager
Pull Request - Ready for CI
19 tasks
jmarrec
requested review from
DavidGoldwasser and
joseph-robertson
and
a lite review from Copilot
August 24, 2026 13:16
There was a problem hiding this comment.
Pull request overview
Updates the Building Component Library (BCL) endpoints used by OpenStudio to the new *.nlr.gov hosts, and refreshes a number of hard-coded URL/email references across tests, documentation, examples, and packaging metadata.
Changes:
- Point
RemoteBCLproduction/development servers tohttps://bcl.nlr.govandhttps://bcl-test.nlr.gov. - Update unit tests and SDK docs that reference BCL URLs.
- Replace multiple non-BCL
*.nrel.govlinks/emails in assorted resources/docs/build metadata with*.nlr.gov.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
src/utilities/idf/Test/IdfObject_GTest.cpp |
Updates a URL-parsing test string that includes a BCL host. |
src/utilities/bcl/test/BCL_GTest.cpp |
Updates comments referencing BCL hosts in BCL unit tests. |
src/utilities/bcl/RemoteBCL.cpp |
Changes the hard-coded production/development BCL base URLs. |
src/model/mainpage.hpp |
Updates the SDK mainpage documentation link to the BCL site. |
resources/utilities/xml/schema/HPXMLBaseElements.xsd |
Updates external documentation links from nrel.gov to nlr.gov. |
resources/utilities/BCL/Measures/v3/SetEplusInfiltration/measure.rb |
Updates header comment links from openstudio.nrel.gov to openstudio.nlr.gov. |
resources/Examples/compact_osw/measures/SetEplusInfiltration/measure.rb |
Updates example measure header comment links to openstudio.nlr.gov. |
resources/energyplus/HospitalBaseline/in.idf |
Updates a reference URL in the example IDF header comments. |
python/module/setup.py |
Updates published package metadata email address. |
doc/index.html |
Updates an external “Buildings Research Home” link domain. |
developer/ruby/PackageOpenStudioGem.rb |
Updates gem metadata email/homepage domains. |
developer/doc/wiki/(v1.4.0 and older) Configuring OpenStudio Build Environments.md |
Updates legacy wiki URLs to *.nlr.gov. |
CMakeLists.txt |
Updates the CPACK package contact email domain. |
Suppressed comments (1)
resources/utilities/xml/schema/HPXMLBaseElements.xsd:2248
- PR scope: this second
www.nrel.gov→www.nlr.govchange is also outside the BCL endpoint update described in the PR title/issue. Please confirm intent or split into a separate PR.
<xs:annotation>
<xs:documentation>[$] The LCOE is the total cost of installing and operating a project expressed in dollars per kilowatt-hour of electricity generated by
the system over its life. Can be calculated with System Advisor Model, a similar software, or through a simplified calculation at
http://www.nlr.gov/analysis/tech_lcoe.html.</xs:documentation>
</xs:annotation>
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+22
to
23
| // Don't bother testing this since bcl7.development.nlr.gov is internal only | ||
| //EXPECT_TRUE(LocalBCL::instance().setDevAuthKey(defaultDevAuthKey)); |
| /// returns true if a download is started | ||
| // TJC 2020-11-19 GetComponentByUID is already testing and dowloading component. | ||
| // https://bcl.nrel.gov/ has issues download some components. Until this behavior is fixed | ||
| // https://bcl.nlr.gov/ has issues download some components. Until this behavior is fixed |
| * added to a local BCL, and/or uploaded to the online %Building %Component Library. (These | ||
| * features are currently under development. Please see the documentation for utilities/bcl and | ||
| * http://bcl.nrel.gov/.) | ||
| * http://bcl.nlr.gov/.) |
Comment on lines
656
to
660
| std::string text = "Schedule:File, \n\ | ||
| Web Schedule, !- Name \n\ | ||
| , !- Schedule Type Limits Name \n\ | ||
| http://bcl.development.nrel.gov/api?search='terms'@xxx.yyy, !- File Name \n\ | ||
| http://bcl.development.nlr.gov/api?search='terms'@xxx.yyy, !- File Name \n\ | ||
| 1, !- Column Number \n\ |
Comment on lines
2082
to
2085
| <xs:documentation>[$] The LCOE is the total cost of installing and operating a project expressed in dollars per kilowatt-hour of electricity generated by | ||
| the system over its life. Can be calculated with System Advisor Model, a similar software, or through a simplified calculation at | ||
| http://www.nrel.gov/analysis/tech_lcoe.html.</xs:documentation> | ||
| http://www.nlr.gov/analysis/tech_lcoe.html.</xs:documentation> | ||
| </xs:annotation> |
Comment on lines
95
to
99
| url="https://github.com/NREL/OpenStudio", | ||
| author="Alliance for Energy Innovation, LLC, and other contributors", | ||
| author_email="openstudio@nrel.gov", | ||
| author_email="openstudio@nlr.gov", | ||
| maintainer="Julien Marrec", | ||
| maintainer_email="contact@effibem.com", |
Comment on lines
10
to
13
| <ul class="list-unstyled"> | ||
| <li><a href="http://www.nrel.gov/buildings/">Buildings Research Home</a></li> | ||
| <li><a href="http://www.nlr.gov/buildings/">Buildings Research Home</a></li> | ||
| <li><a href="http://apps1.eere.energy.gov/buildings/energyplus/">DOE EnergyPlus Site</a></li> | ||
| <li><a href="http://apps1.eere.energy.gov/buildings/energyplus/openstudio_suite.cfm">DOE OpenStudio Site</a></li> |
Comment on lines
38
to
42
| s.version = "#{$ZeroKit_MajorVersion}.#{$ZeroKit_MinorVersion}.#{patch}" | ||
| s.author = "NREL Commercial Buildings Research" | ||
| s.email = "zerokit@nrel.gov" | ||
| s.homepage = "http://cbr.nrel.gov/zerokit/" | ||
| s.email = "zerokit@nlr.gov" | ||
| s.homepage = "http://cbr.nlr.gov/zerokit/" | ||
| s.rubyforge_project = 'zerokit' |
Comment on lines
63
to
75
| @@ -71,7 +71,7 @@ Install [CMake](http://www.cmake.org/files/v3.0/cmake-3.0.0-win32-x86.exe) | |||
|
|
|||
| Install [EnergyPlus 8.1](http://apps1.eere.energy.gov/buildings/energyplus/register.cfm?goto=eplus) | |||
|
|
|||
| Optionally extract [Ruby](http://developer.nrel.gov/downloads/buildings/openstudio/src/ruby-1.8.6-msvc-ssl.zip) to `C:\Ruby` if you want a convenient location to access the OpenStudio Ruby bindings | |||
| Optionally extract [Ruby](http://developer.nlr.gov/downloads/buildings/openstudio/src/ruby-1.8.6-msvc-ssl.zip) to `C:\Ruby` if you want a convenient location to access the OpenStudio Ruby bindings | |||
| > _v1.8.6 MSVC tested and working_ | |||
Comment on lines
1387
to
1390
| # The actual .deb file name on disk | ||
| set(CPACK_PACKAGE_FILE_NAME "${CMAKE_PROJECT_NAME}-${OPENSTUDIO_LONG_VERSION}-${CMAKE_SYSTEM_NAME}") | ||
| set(CPACK_PACKAGE_CONTACT "openstudio@nrel.gov") | ||
| set(CPACK_PACKAGE_CONTACT "openstudio@nlr.gov") | ||
|
|
Contributor
🧪 Test Results DashboardSummary
|
| Run | XML File | Status |
|---|---|---|
| run1 | results.xml |
✅ Found |
| run3 | results.xml |
✅ Found |
| run2 | results.xml |
✅ Found |
Collaborator
Author
|
the Build and Test is complety broken. It reports EPMOdelFixture and we don't have epmodel in either the feature branch or the target branch (=develop) |
Collaborator
Author
|
Ok that's good enough for me. I'm merging @kbenne |
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
Pull Request Author
src/model/test)src/energyplus/Test)src/osversion/VersionTranslator.cpp)Labels:
IDDChangeAPIChangePull Request - Ready for CIso that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.