Skip to content

GHP standard model improvements #2208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
yzhou601 wants to merge 13 commits into
base: master
Choose a base branch
from
Draft

GHP standard model improvements #2208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
b196632
updates to standard ghp models
yzhou601 Apr 30, 2026
8baaf5b
Latest results. [skip ci]
Apr 30, 2026
1f5d4b7
fix wrong power curve
yzhou601 May 1, 2026
057059b
Merge branch 'ghp_standard_improvements' of https://github.com/NREL/O…
yzhou601 May 1, 2026
c2e13a0
Latest results. [skip ci]
May 1, 2026
d7e7397
commented the rated water temperature
yzhou601 May 11, 2026
9eaf63b
Merge branch 'ghp_standard_improvements' of https://github.com/NREL/O…
yzhou601 May 11, 2026
04f9ddb
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
yzhou601 May 11, 2026
5edd9a4
Latest results. [skip ci]
May 11, 2026
4831784
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
yzhou601 Jun 1, 2026
8965f6f
update heating coefficients
yzhou601 Jun 1, 2026
bce4853
small change on hvac sizing, to avoid curve value to be over 1 and si…
yzhou601 Jun 1, 2026
d6d9411
Latest results. [skip ci]
Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions HPXMLtoOpenStudio/resources/defaults.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7923,15 +7923,17 @@ def self.interpolate_seer2(seer2, eer2, seer2_array, seer2_eer2_ratio_array, cop
clg_ap.cool_capacity_ratios = [1.0]

# E+ equation fit coil coefficients generated following approach in Tang's thesis:
# See Appendix B of https://shareok.org/bitstream/handle/11244/10075/Tang_okstate_0664M_1318.pdf?sequence=1&isAllowed=y
# Coefficients generated by catalog data: https://files.climatemaster.com/Genesis-GS-Series-Product-Catalog.pdf, p180
# See Appendix B of https://openresearch.okstate.edu/server/api/core/bitstreams/75bae825-3f8e-4ad0-b08d-59d33b89eac3/content
# Coefficients generated by catalog data: https://www.climatemaster.com/download/18.274be999165850ccd5b5b73/1535543867815/lc377-climatemaster-commercial-tranquility-20-single-stage-ts-series-water-source-heat-pump-submittal-set.pdf
# Data point taken as rated condition:
# EWT: 80F EAT:80/67F, AFR: 1200cfm, WFR: 4.5gpm
# EWT: 77F EAT:80/67F, AFR: 1200cfm, WFR: 9.0GPM
# Note: Product's ANSI/AHRI/ASHRAE ISO Standard 13256 table doesn't specify fluid flow rate;
# Took largest GPM because it gave higher COP/EER that's closer to ANSI/AHRI/ASHRAE ISO Standard 13256 rated values)

# Cooling Curves
clg_ap.cool_cap_curve_spec = [[-5.45013866666657, 7.42301402824225, -1.43760846638838, 0.249103937703341, 0.0378875477019811]]
clg_ap.cool_power_curve_spec = [[-4.21572180554818, 0.322682268675807, 4.56870615863483, 0.154605773589744, -0.167531037948482]]
clg_ap.cool_sh_curve_spec = [[0.56143829895505, 18.7079597251858, -19.1482655264078, -0.138154731772664, 0.4823357726442, -0.00164644360129174]]
clg_ap.cool_cap_curve_spec = [[-5.36131548088001, 7.30203806881921, -1.41417916086981, 0.24504418680527, 0.0372700785153022]]
clg_ap.cool_power_curve_spec = [[-5.38279096451938, 0.412012765636504, 5.83349456262934, 0.197406422797103, -0.213909882800589]]
clg_ap.cool_sh_curve_spec = [[0.552252763485081, 18.4018840120962, -18.8349860928753, -0.135894420725405, 0.474444411548241, -0.00161950659658672]]

cool_cop_ratios = [1.0]

Expand Down Expand Up @@ -8128,14 +8130,15 @@ def self.interpolate_hspf2(hspf2, qm17full, hspf2_array, qm17full_array, cop47fu
when HPXML::GroundToAirHeatPumpModelTypeStandard
htg_ap.heat_capacity_ratios = [1.0]
# E+ equation fit coil coefficients following approach from Tang's thesis:
# See Appendix B Figure B.3 of https://shareok.org/bitstream/handle/11244/10075/Tang_okstate_0664M_1318.pdf?sequence=1&isAllowed=y
# See Appendix B Figure B.3 of https://openresearch.okstate.edu/server/api/core/bitstreams/75bae825-3f8e-4ad0-b08d-59d33b89eac3/content
# Coefficients generated by catalog data: https://www.climatemaster.com/download/18.274be999165850ccd5b5b73/1535543867815/lc377-climatemaster-commercial-tranquility-20-single-stage-ts-series-water-source-heat-pump-submittal-set.pdf
# Data point taken as rated condition:
# EWT: 60F EAT: 70F AFR: 1200 cfm, WFR: 4.5 gpm
# EWT: 32F EAT: 70F AFR: 1200 cfm, WFR: 4.5 gpm
# FIXME: Update heating coefficients with 9.0 gpm

# Heating Curves
htg_ap.heat_cap_curve_spec = [[-3.75031847962047, -2.18062040443483, 6.8363364819032, 0.188376814356582, 0.0869274802923634]]
htg_ap.heat_power_curve_spec = [[-8.4754723813072, 8.10952801956388, 1.38771494628738, -0.33766445915032, 0.0223085217874051]]
htg_ap.heat_cap_curve_spec = [[-4.15575838697543, -2.41636319256641, 7.57540001609313, 0.208741878970691, 0.19265009478362]]
htg_ap.heat_power_curve_spec = [[-10.1331922905183, 9.69567277321437, 1.65913848367526, -0.403708340999133, 0.0533437030572159]]
heat_cop_ratios = [1.0]
when HPXML::GroundToAirHeatPumpModelTypeExperimental
case heating_system.compressor_type
Expand Down
6 changes: 4 additions & 2 deletions HPXMLtoOpenStudio/resources/hvac.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -626,7 +626,8 @@ def self.apply_ground_source_heat_pump(runner, model, weather, hpxml_bldg, hpxml
clg_coil.setRatioofInitialMoistureEvaporationRateandSteadyStateLatentCapacity(1.5)
clg_coil.setRatedAirFlowRate(clg_air_flow_rated)
clg_coil.setRatedWaterFlowRate(UnitConversions.convert(geothermal_loop.loop_flow, 'gal/min', 'm^3/s'))
clg_coil.setRatedEnteringWaterTemperature(UnitConversions.convert(80, 'F', 'C'))
# RatedEnteringWaterTemperature is not impacting results, only used in E+ sizing
# clg_coil.setRatedEnteringWaterTemperature(UnitConversions.convert(77, 'F', 'C'))
clg_coil.setRatedEnteringAirDryBulbTemperature(UnitConversions.convert(80, 'F', 'C'))
clg_coil.setRatedEnteringAirWetBulbTemperature(UnitConversions.convert(67, 'F', 'C'))
# TODO: Add net to gross conversion after RESNET PR: https://github.com/NatLabRockies/OpenStudio-HPXML/pull/1879
Expand All @@ -648,7 +649,8 @@ def self.apply_ground_source_heat_pump(runner, model, weather, hpxml_bldg, hpxml
htg_coil.setRatedHeatingCoefficientofPerformance(hp_ap.heat_rated_cops[0])
htg_coil.setRatedAirFlowRate(htg_air_flow_rated)
htg_coil.setRatedWaterFlowRate(UnitConversions.convert(geothermal_loop.loop_flow, 'gal/min', 'm^3/s'))
htg_coil.setRatedEnteringWaterTemperature(UnitConversions.convert(60, 'F', 'C'))
# RatedEnteringWaterTemperature is not impacting results, only used in E+ sizing
# htg_coil.setRatedEnteringWaterTemperature(UnitConversions.convert(32, 'F', 'C'))
htg_coil.setRatedEnteringAirDryBulbTemperature(UnitConversions.convert(70, 'F', 'C'))
# TODO: Add net to gross conversion after RESNET PR: https://github.com/NatLabRockies/OpenStudio-HPXML/pull/1879
htg_coil.setRatedHeatingCapacity(UnitConversions.convert(heat_pump.heating_capacity, 'Btu/hr', 'W'))
Expand Down
2 changes: 1 addition & 1 deletion HPXMLtoOpenStudio/resources/hvac_sizing.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2912,7 +2912,7 @@ def self.apply_hvac_equipment_adjustments(mj, runner, hvac_sizings, weather, hva
gl_ap = hvac_heating.geothermal_loop.additional_properties
hvac_heating_speed = get_nominal_speed(htg_ap, false)
htg_cap_curve_value = calc_gshp_htg_curve_value(htg_ap, hpxml_header, mj.heat_setpoint, gl_ap.design_hw, hvac_heating_speed)
hvac_sizings.Heat_Capacity = hvac_sizings.Heat_Load / htg_cap_curve_value
hvac_sizings.Heat_Capacity = [hvac_sizings.Heat_Load / htg_cap_curve_value, hvac_sizings.Heat_Load].max
hvac_sizings.Heat_Capacity_Supp = hvac_sizings.Heat_Load_Supp
if hvac_sizings.Cool_Capacity > 0
if (hpxml_header.ground_to_air_heat_pump_model_type == HPXML::GroundToAirHeatPumpModelTypeStandard) && (hvac_heating.compressor_type == HPXML::HVACCompressorTypeSingleStage)
Expand Down
Loading