Add unmet water heater loads EMS program#1502

Draft

jmaguire1 wants to merge 136 commits into

Commits on Oct 4, 2023

Commits on Oct 5, 2023

First cut at setting up annual unmet water heating loads.
Joe Robertson
committed
Merge branch 'master' into unmet_wh_loads
Joe Robertson
committed

Commits on Oct 6, 2023

Wrong direction for sag calculation
jmaguire1
committed

Commits on Oct 30, 2023

Still in progress, but: working on restructuring the calculation based on some discussions with Joe. Still need to connect the EMS sensor for WH outlet temperature.
jmaguire1
committed

Commits on Nov 1, 2023

rename constant for consistency with schedule:file
jmaguire1
committed

Commits on Nov 16, 2023

Major refactor of the unmet WH load calculation
jmaguire1
committed

Commits on Dec 4, 2023

Fix unmet energy calc (incorrectly passing shower peak flow rate)
jmaguire1
committed

Commits on Jan 10, 2024

Commits on Jan 17, 2024

Update some output variable names, add showers to unavailable_periods.csv
jmaguire1
committed

Commits on Jan 24, 2024

Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into unmet_wh_loads
jmaguire1
committed
Bit of code cleanup and adding FIXMEs to address.
Joe Robertson
committed
Oops, showers_schedule_obj does get used.
Joe Robertson
committed

Commits on Feb 5, 2024

Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into unmet_wh_loads
jmaguire1
committed

Commits on Apr 10, 2024

Commits on May 14, 2024

Commits on May 28, 2024

Some fixes for unmet showers with multiple WHs.
jmaguire1
committed

Commits on Jul 24, 2024

Bunch of cleanup and test updates.
Joe Robertson
committed
Try a sample file with undersized tank water heater.
Joe Robertson
committed
Remove warning for both shower schedule types provided.
Joe Robertson
committed
Update reporting measure with include argument for unmet loads timeseries.
Joe Robertson
committed
Update reporting measure test for unmet loads outputs.
Joe Robertson
committed
Update run_simulation with unmet loads timeseries request option.
Joe Robertson
committed
Start updating the docs.
Joe Robertson
committed
Update the changelog entry.
Joe Robertson
committed
Few more fixes and updates.
Joe Robertson
committed
Fix comments. [ci skip]
Joe Robertson
committed
Catch target water temperature warnings for new dhw undersized sample file.
Joe Robertson
committed
Minor fix to ems program.
Joe Robertson
committed
Update the docs. [ci skip]
Joe Robertson
committed
Spaces in ems program and exceptions for 10x checks.
Joe Robertson
committed
Latest results.
GitHub Action
committed
Change energy annual units to kBtu and timeseries units to Btu.
Joe Robertson
committed
Relax expected results for dhw-undersized.
Joe Robertson
committed

Commits on Jul 25, 2024

Updates due to output name change.
Joe Robertson
committed
Latest results.
GitHub Action
committed
Clean up loop that finds appropriate tank.
Joe Robertson
committed
Add sample files for undersized tankless, heat pump, and multiple.
Joe Robertson
committed
Refactor unmet loads program for multiple water heaters.
Joe Robertson
committed
Clean up expected warnings and checks.
Joe Robertson
committed
Typo.
Joe Robertson
committed
Expect err and run log warnings.
Joe Robertson
committed
Latest results.
GitHub Action
committed

Commits on Aug 6, 2024

Commits on Aug 7, 2024

Merge branch 'master' into unmet_wh_loads
Joe Robertson
committed
Try WarmupFlag in program to avoid counting first timestep.
Joe Robertson
committed
Add unmet loads method for building-level EMS program.
Joe Robertson
committed

Commits on Aug 8, 2024

Merge branch 'master' into unmet_wh_loads
Joe Robertson
committed
Skip building-level EMS program if no water heating systems.
Joe Robertson
committed
Try changing unit multiplier tolerances.
Joe Robertson
committed
Latest results.
GitHub Action
committed

Commits on Aug 13, 2024

Merge branch 'master' into unmet_wh_loads
Joe Robertson
committed
Latest results.
GitHub Action
committed

Commits on Sep 3, 2024

Commits on Sep 11, 2024

Commits on Sep 18, 2024

Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into unmet_wh_loads
shorowit
committed
Latest results.
GitHub Action
committed

Commits on Sep 24, 2024

Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into unmet_wh_loads
shorowit
committed
Latest results.
GitHub Action
committed

Commits on Sep 25, 2024

Merge branch 'master' into unmet_wh_loads
Joe Robertson
committed
Updates to sample files and reported outputs.
Joe Robertson
committed

Commits on Oct 1, 2024

Merge branch 'master' into unmet_wh_loads
Joe Robertson
committed
Clean up new methods and fill out TODOs.
Joe Robertson
committed
Get name of the schedule, not the object.
Joe Robertson
committed
Avoid divide by zero when no dhw.
Joe Robertson
committed
Merge branch 'master' into unmet_wh_loads
Joe Robertson
committed
Update reporting measure descriptions and tests.
Joe Robertson
committed
Revert stuff in workflow tests util file.
Joe Robertson
committed
Update the docs. [ci skip]
Joe Robertson
committed
Latest results.
GitHub Action
committed

Commits on Oct 10, 2024

Merge branch 'master' into unmet_wh_loads
Joe Robertson
committed
Update the changelog.
Joe Robertson
committed
Latest results.
GitHub Action
committed

Commits on Oct 14, 2024

Merge branch 'master' into unmet_wh_loads
Joe Robertson
committed
Latest results.
GitHub Action
committed

Commits on Nov 8, 2024

Merge branch 'master' into unmet_wh_loads
Joe Robertson
committed
Create a second sample file with 1 gal tank and 10-min stochastic schedules.
Joe Robertson
committed
Latest results.
GitHub Action
committed
Shorten new sample file timestep to 10 min.
Joe Robertson
committed
Merge branch 'unmet_wh_loads' of github.com:NREL/OpenStudio-HPXML into unmet_wh_loads
Joe Robertson
committed

Commits on Nov 11, 2024

Regenerate 10-min stochastic occupancy csv file.
Joe Robertson
committed
Latest results.
GitHub Action
committed

Commits on Nov 13, 2024

Merge branch 'master' into unmet_wh_loads
Joe Robertson
committed
Latest results.
GitHub Action
committed

Commits on Dec 12, 2024

Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into unmet_wh_loads
shorowit
committed

Commits on Dec 13, 2024

Commits on Dec 31, 2024

Commits on Jan 9, 2025

Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into unmet_wh_loads
shorowit
committed
Fix CI failures
shorowit
committed
Latest results.
GitHub Action
committed

Commits on Jun 6, 2025

Merge branch 'master' into unmet_wh_loads
Joe Robertson
committed
Merge branch 'master' into unmet_wh_loads
Joe Robertson
committed
Update reporting measure for hot water shower constants.
Joe Robertson
committed
Regenerate hpxml files and update schedule_files README.
Joe Robertson
committed
Add test files for HPWH with nonzero unmet showers.
Joe Robertson
committed
Fix validation test.
Joe Robertson
committed
Typo in new HPWH undersized sample files.
Joe Robertson
committed
Latest results.
GitHub Action
committed

Commits on Jun 24, 2025

Changes for minutes of shower use when doing unmet shower calcs. Still doing some testing.
jmaguire1
committed