Fix availability schedules for Coil:Cooling:WaterToAirHeatPump:EquationFit (and Heating) - #11782
Open
joseph-robertson wants to merge 6 commits into
Open
Fix availability schedules for Coil:Cooling:WaterToAirHeatPump:EquationFit (and Heating)#11782joseph-robertson wants to merge 6 commits into
joseph-robertson wants to merge 6 commits into
Conversation
joseph-robertson
commented
Sep 3, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The unitary-system schedule propagation lacks regression coverage.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Ensures water-to-air heat pump coils honor their availability schedules.
Changes:
- Gates initialization and calculations on schedule availability.
- Propagates coil schedules into unitary-system control.
- Adds direct cooling and heating schedule-off tests.
File summaries
| File | Description |
|---|---|
src/EnergyPlus/WaterToAirHeatPumpSimple.cc |
Enforces availability schedules. |
src/EnergyPlus/UnitarySystem.cc |
Uses underlying coil schedules. |
tst/EnergyPlus/unit/WaterToAirHeatPumpSimple.unit.cc |
Tests unavailable coil behavior. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+507
to
+510
| state->dataWaterToAirHeatPumpSimple->SimpleWatertoAirHP(HPNum).availSched = Sched::GetScheduleAlwaysOff(*state); | ||
| InitSimpleWatertoAirHP(*state, HPNum, SensLoad, LatentLoad, fanOp, OnOffAirFlowRatio, FirstHVACIteration, PartLoadRatio); | ||
| CalcHPCoolingSimple(*state, HPNum, fanOp, SensLoad, LatentLoad, compressorOp, PartLoadRatio, OnOffAirFlowRatio); | ||
| UpdateSimpleWatertoAirHP(*state, HPNum); |
joseph-robertson
commented
Sep 4, 2026
| auto const &thisHeatCoil = state.dataVariableSpeedCoils->VarSpeedCoil(this->m_HeatingCoilIndex); | ||
| this->m_NumOfSpeedHeating = thisHeatCoil.NumOfSpeeds; | ||
| this->m_heatingCoilAvailSched = Sched::GetScheduleAlwaysOn(state); | ||
| this->m_heatingCoilAvailSched = thisHeatCoil.availSched; |
Collaborator
Author
There was a problem hiding this comment.
@rraustad These updates (and all similar down below) are legitimate and necessary changes?
Collaborator
There was a problem hiding this comment.
@joseph-robertson These changes look correct to me. i.e., do not use the assumed AlwaysOn schedule within UnitarySystem and instead use the coils availSched which will handle a blank field.
joseph-robertson
marked this pull request as ready for review
September 8, 2026 17:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
Description of the purpose of this PR
Pull Request Author
Reviewer