Skip to content

Unbrick Windows Doc PDF builds by removing l3backend from the preinstall package list - #11779

Merged
mitchute merged 1 commit into
developfrom
fix_windows_doc_pdf
Sep 3, 2026
Merged

Unbrick Windows Doc PDF builds by removing l3backend from the preinstall package list#11779
mitchute merged 1 commit into
developfrom
fix_windows_doc_pdf

Conversation

@jmarrec

@jmarrec jmarrec commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Pull request overview

doc: remove l3backend from Windows MiKTeX package list (merged in l3kernel)

https://www.ctan.org/ctan-ann/id/b6ae11eda9580e94@hogwart

Date: August 18, 2026 1:29:37 PM CEST
The LaTeX Project Team submitted an update to the

                l3kernel

package.

Version: 2026-08-10
License: lppl1.3c

Summary description: LaTeX3 programming conventions

Announcement text:## [2026-08-10]

### Changed

- Integrate `l3backend` files into `l3kernel` distribution

MiKTeX's CTAN mirror no longer serves l3backend as a standalone package (merged into l3kernel upstream), so mpm --require was failing outright with "The requested package is unknown". Since mpm aborts the whole batch on an unknown package, none of the listed packages (including xkeyval) got pre-installed, causing the PDF doc build to fail with "File xkeyval.sty not found".

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies
  • If adding/removing any output files (e.g., eplustbl.*)
    • Update ..\scripts\Epl-run.bat
    • Update ..\scripts\RunEPlus.bat
    • Update ..\src\EPLaunch\ MainModule.bas, epl-ui.frm, and epl.vbp (VersionComments)
    • Update ...github\workflows\energyplus.py

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

…ernel)

https://www.ctan.org/ctan-ann/id/b6ae11eda9580e94@hogwart

```
Date: August 18, 2026 1:29:37 PM CEST
The LaTeX Project Team submitted an update to the

                l3kernel

package.

Version: 2026-08-10
License: lppl1.3c

Summary description: LaTeX3 programming conventions

Announcement text:## [2026-08-10]

### Changed

- Integrate `l3backend` files into `l3kernel` distribution
```

MiKTeX's CTAN mirror no longer serves l3backend as a standalone package (merged into l3kernel upstream), so mpm --require was failing outright with "The requested package is unknown". Since mpm aborts the whole batch on an unknown package, none of the listed packages (including xkeyval) got pre-installed, causing the PDF doc build to fail with "File xkeyval.sty not found".
@jmarrec jmarrec self-assigned this Sep 3, 2026
@jmarrec jmarrec added Defect Includes code to repair a defect in EnergyPlus Developer Issue Related to cmake, packaging, installers, or developer tooling (CI, etc) labels Sep 3, 2026
@jmarrec

jmarrec commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

@jmarrec
jmarrec requested a review from mitchute September 3, 2026 14:18
@mitchute
mitchute merged commit 5b89884 into develop Sep 3, 2026
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Defect Includes code to repair a defect in EnergyPlus Developer Issue Related to cmake, packaging, installers, or developer tooling (CI, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants